Mipmaps Gen: default load/store depth & stencil actions to dont_care

CompositorPassMipmap doesn't even call setRenderPassDescToCurrent(), however setting up the RTV is still important for analyzeBarriers() to do its job properly. But we don't use the depth or stencil buffers at all. This reverts commit 4948d0a since it does the same job, but cleaner.
OGRECave · Dec 11, 2024 · 0d20133 · 0d20133
1 parent 4948d0a
commit 0d20133
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 40 deletions.
diff --git a/OgreMain/include/Compositor/Pass/PassMipmap/OgreCompositorPassMipmapDef.h b/OgreMain/include/Compositor/Pass/PassMipmap/OgreCompositorPassMipmapDef.h
@@ -80,6 +80,10 @@ namespace Ogre
             mGaussianDeviationFactor( 0.5f ),
             mKernelRadius( 8 )
         {
+            mLoadActionDepth = LoadAction::DontCare;
+            mLoadActionStencil = LoadAction::DontCare;
+            mStoreActionDepth = StoreAction::DontCare;
+            mStoreActionStencil = StoreAction::DontCare;
         }
     };
 

diff --git a/Samples/Media/2.0/scripts/Compositors/PlanarReflections.compositor b/Samples/Media/2.0/scripts/Compositors/PlanarReflections.compositor
@@ -57,16 +57,6 @@ compositor_node PlanarReflectionsReflectiveRenderingNode
 
 		pass generate_mipmaps
 		{
-		    load
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
-            store
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
 			mipmap_method compute_hq
 
 			profiling_id "Mipmap Generation (HQ)"

diff --git a/Samples/Media/2.0/scripts/Compositors/ScreenSpaceReflections.compositor b/Samples/Media/2.0/scripts/Compositors/ScreenSpaceReflections.compositor
@@ -184,16 +184,6 @@ compositor_node ScreenSpaceReflectionsPostprocessNode
 
 		pass generate_mipmaps
 		{
-		    load
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
-            store
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
 			mipmap_method compute_hq
 		}
 	}

diff --git a/Samples/Media/2.0/scripts/materials/Tutorial_Terrain/GpuNormalMapper.compositor b/Samples/Media/2.0/scripts/materials/Tutorial_Terrain/GpuNormalMapper.compositor
@@ -11,16 +11,6 @@ compositor_node Terra/GpuNormalMapper
 
 		pass generate_mipmaps
 		{
-		    load
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
-            store
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
 		}
 	}
 }
@@ -43,16 +33,6 @@ compositor_node Terra/GpuNormalMapperU16
 
 		pass generate_mipmaps
 		{
-		    load
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
-            store
-            {
-                depth	dont_care
-                stencil	dont_care
-            }
 		}
 	}
 }