Request header invalid 6415 v1 #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that following headers and response still get processed Ticket: #6415
For instance, the following header may be considered as valid: Transfer-Encoding: chunked, chunked Ticket: #6415
| @@ -405,7 +405,7 @@ static htp_status_t htp_tx_process_request_headers(htp_tx_t *tx) { | |||
| // (2.2.22 on Ubuntu 12.04 LTS) instead errors out with "Unknown Transfer-Encoding: identity". | |||
| // And it behaves strangely, too, sending a 501 and proceeding to process the request | |||
| // (e.g., PHP is run), but without the body. It then closes the connection. | |||
| if (bstr_cmp_c_nocase(te->value, "chunked") != 0) { | |||
| if (bstr_index_of_c_nocasenorzero(te->value, "chunked") == -1) { | |||
There was a problem hiding this comment.
should we tokenize value first? This will also match notchunked or chunkeditisnot?
There was a problem hiding this comment.
Indeed, it will get more complex
|
Replaced by #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/6415