Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thresholds/v20 #11358

Closed
wants to merge 25 commits into from
Closed

Thresholds/v20 #11358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
966dd63
util/var: remove printf; add assert
victorjulien Mar 1, 2024
feda2d7
util/var: add comments explaining types
victorjulien Mar 4, 2024
6e82c82
detect/threshold: implement tracking 'by_flow'
victorjulien Feb 27, 2024
f15cf52
threshold: add by_flow support for global thresholds
victorjulien Mar 2, 2024
deb16f9
detect: group types used in traffic variables
victorjulien Mar 4, 2024
b0944c6
detect: group content inspect keyword id's
victorjulien Mar 5, 2024
fc7f1e9
detect/content: fix wrong value for depth check
victorjulien Mar 5, 2024
3567f9e
doc: add thresholding by_flow
victorjulien Mar 8, 2024
06ff741
detect/detection_filter: add support for track by_flow
victorjulien Mar 13, 2024
783d735
detect: add ticket id to var related todos
victorjulien Mar 13, 2024
6bc0795
detect/threshold: implement per thread cache
victorjulien Sep 11, 2023
75ea5fc
detect/threshold: minor cleanup
victorjulien Jan 9, 2024
da3439f
detect/threshold: minor code cleanup
victorjulien Jan 9, 2024
6d17006
detect/threshold: minor rate filter cleanup
victorjulien Jan 9, 2024
21a4cfc
detect/address: constify ipv6 cmp funcs
victorjulien Jan 9, 2024
58a116c
thash: add expiration logic
victorjulien Jan 10, 2024
f83901c
range: use thash expiry API for timeout
victorjulien Jan 9, 2024
f3210fc
thresholds: use dedicated storage
victorjulien Jan 9, 2024
1432add
detect/threshold: improve hash function
victorjulien Apr 19, 2024
cccf858
detect/threshold: include rev in threshold tracking
victorjulien Apr 19, 2024
44dcc92
detect/threshold: consider tenant id in tracking
victorjulien Apr 19, 2024
11cf1a9
detect/threshold: expand cache support for rule tracking
victorjulien Apr 19, 2024
470a37c
detect/threshold: includes cleanup
victorjulien Apr 20, 2024
1fb11d0
detect/threshold: make hash size and memcap configurable
victorjulien May 15, 2024
dac619d
doc/userguide: document new threshold config options
victorjulien May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/detect-detection-filter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ static int DetectDetectionFilterTestSig1(void)
ThreadVars th_v;
DetectEngineThreadCtx *det_ctx;

HostInitConfig(HOST_QUIET);
ThresholdInit();

memset(&th_v, 0, sizeof(th_v));

Expand Down Expand Up @@ -418,7 +418,7 @@ static int DetectDetectionFilterTestSig1(void)
DetectEngineCtxFree(de_ctx);

UTHFreePackets(&p, 1);
HostShutdown();
ThresholdDestroy();

PASS;
}
Expand All @@ -435,7 +435,7 @@ static int DetectDetectionFilterTestSig2(void)
ThreadVars th_v;
DetectEngineThreadCtx *det_ctx;

HostInitConfig(HOST_QUIET);
ThresholdInit();

memset(&th_v, 0, sizeof(th_v));

Expand Down Expand Up @@ -480,7 +480,7 @@ static int DetectDetectionFilterTestSig2(void)
DetectEngineCtxFree(de_ctx);

UTHFreePackets(&p, 1);
HostShutdown();
ThresholdDestroy();

PASS;
}
Expand All @@ -493,7 +493,7 @@ static int DetectDetectionFilterTestSig3(void)
ThreadVars th_v;
DetectEngineThreadCtx *det_ctx;

HostInitConfig(HOST_QUIET);
ThresholdInit();

memset(&th_v, 0, sizeof(th_v));

Expand Down Expand Up @@ -556,7 +556,7 @@ static int DetectDetectionFilterTestSig3(void)
DetectEngineCtxFree(de_ctx);

UTHFreePackets(&p, 1);
HostShutdown();
ThresholdDestroy();

PASS;
}
Expand Down
2 changes: 0 additions & 2 deletions src/detect-engine-build.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2219,8 +2219,6 @@ int SigGroupBuild(DetectEngineCtx *de_ctx)
SCProfilingRuleInitCounters(de_ctx);
#endif

ThresholdHashAllocate(de_ctx);

if (!DetectEngineMultiTenantEnabled()) {
VarNameStoreActivate();
}
Expand Down
Loading