Applayer plugin 5053 v2.2 #11363
Closed
Applayer plugin 5053 v2.2 #11363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jufajardini,
victorjulien and
a team
as code owners
|
ERROR: ERROR: QA failed on build_asan. Pipeline 21207 |
FLOW_PROTO_APPLAYER_MAX
OutputTxLoggerThreadData gets allocated after the number of app-layer protos is definite
catenacyber
force-pushed
the
applayer-plugin-5053-v2.2
branch
from
0b4866f to
04117ad
Compare
|
ERROR: ERROR: QA failed on ASAN_TLPR1_cfg. Pipeline 21241 |
|
Continued in #11373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
Small PR good in itself.
#11355 fixing compile warning and taking in 2 nits/cleanups commits
Still more work to do : I guess stack allocated arrays are fine, but the global variables cf
git grep '\[ALPROTO_MAX'likesrc/runmodes.c:static LoggerId logger_bits[ALPROTO_MAX];need to be allocated and freed, and the app-layer init needs to be taken care of, so that we knowALPROTO_MAXfinal value...