Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: parse units for integer for every cases #11379

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Follow up on https://redmine.openinfosecfoundation.org/issues/6423 commit ae72ce7

Describe changes:

  • detect: parse units for integer for every cases (and not just equality)

To allow flow.bytes_toserver:>3MB; in signature

Ticket: OISF#6423

Not just equality, but also >3MB should work
For example flow.bytes_toserver>3MB
@catenacyber catenacyber requested a review from jasonish as a code owner June 27, 2024 11:50
@inashivb inashivb self-requested a review July 2, 2024 04:54
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21345

@victorjulien victorjulien added this to the 8.0 milestone Jul 3, 2024
@victorjulien
Copy link
Member

Merged in #11408, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants