Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applayer: remove truncation logic #11393

Closed
wants to merge 1 commit into from
Closed

applayer: remove truncation logic #11393

wants to merge 1 commit into from

Conversation

inashivb
Copy link
Member

@inashivb inashivb commented Jun 28, 2024 •
edited
Loading

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7044

SV_BRANCH=OISF/suricata-verify#1946

Previous PR: #11151

Changes since v1:

  • changed the entire approach

TODO: Remove truncate glue code and parser specific calls

@inashivb inashivb requested a review from catenacyber June 28, 2024 16:00
@inashivb inashivb force-pushed the discard-truncate-fn/v1 branch from 5510e09 to f45e7f9 Compare June 28, 2024 16:02
@inashivb
Copy link
Member Author

Hey @catenacyber !
Is this in accordance with your proposal? s-v passed locally but I'm waiting for the QA.
I'm unsure about the changes as there are too many moving parts incl file handling related to these flags and logic. I don't know if this will cause any unknown side effects.
Lmk if you see any obvious mistakes. Thanks a lot!

@victorjulien
Copy link
Member

Passed my QA. Ran this PR with SV PR OISF/suricata-verify#1946. Local pipeline 4967, run 512.

@victorjulien
Copy link
Member

possibly related daffcc6

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21330

@inashivb inashivb mentioned this pull request Jul 3, 2024
Closed
@inashivb inashivb closed this Jul 3, 2024
@inashivb inashivb deleted the discard-truncate-fn/v1 branch July 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber Awaiting requested review from catenacyber

@jasonish jasonish Awaiting requested review from jasonish jasonish will be requested when the pull request is marked ready for review jasonish is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien will be requested when the pull request is marked ready for review victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inashivb @victorjulien @suricata-qa