Applayer plugin 5053 v3.2 #11696
Closed
Applayer plugin 5053 v3.2 #11696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of a global variable. For easier initialization with dynamic number of protocols
for expectation_proto Ticket: 5053
for alproto_names Ticket: 5053
Ticket: 5053
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 22315 |
Ticket: 5053 delay after initialization so that StringToAppProto works
so that we can use safely EXCEPTION_POLICY_MAX*sizeof(x)
catenacyber
force-pushed
the
applayer-plugin-5053-v3.2
branch
from
94b94a4 to
6547368
Compare
|
Draft to see CI with array dimensions well ordered.. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11696 +/- ##
==========================================
- Coverage 82.63% 82.43% -0.21%
==========================================
Files 919 919
Lines 249032 248933 -99
==========================================
- Hits 205795 205201 -594
- Misses 43237 43732 +495
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 22316 |
|
Information: QA ran without warnings. Pipeline 22320 |
|
Clean in #11701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
#11572 next round
Still more work to do after :
Only
AppProtoStringsis to be handled, but it is the big one.And then take remaining commits out of #11321
And supply an example of an app-layer plugin