Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: fix clippy lint warnings #12275

Closed
wants to merge 1 commit into from
Closed

Conversation

inashivb
Copy link
Member

No description provided.

Fix vector lint issues:
- same_item_push
- vec_init_then_push
@inashivb inashivb requested a review from jasonish as a code owner December 13, 2024 07:06
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (0e4faba) to head (2280b2b).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12275      +/-   ##
==========================================
+ Coverage   83.22%   83.25%   +0.02%     
==========================================
  Files         912      912              
  Lines      257311   257610     +299     
==========================================
+ Hits       214154   214479     +325     
+ Misses      43157    43131      -26     
Flag Coverage Δ
fuzzcorpus 61.08% <ø> (+0.01%) ⬆️
livemode 19.39% <ø> (-0.13%) ⬇️
pcap 44.48% <ø> (+0.11%) ⬆️
suricata-verify 62.88% <ø> (+0.04%) ⬆️
unittests 59.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Dec 13, 2024
@victorjulien victorjulien removed this from the 8.0 milestone Dec 13, 2024
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23956

@inashivb inashivb closed this Dec 16, 2024
@inashivb inashivb deleted the minor-clippy/v1 branch December 16, 2024 05:20
@victorjulien
Copy link
Member

Replaced by #12284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants