[gpkg] Also read relationships defined using foreign key constraints #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Feb 22, 2024
nyalldawson
force-pushed
the
gpkg_one_to_many
branch
from
288977e to
9d207db
Compare
When reading relationships, always read relationships defined using foreign key constraints regardless of whether or not the related tables extension is in use. The related table extension only permits definition of many-to-many relationships, so there's a strong case for supporting one-to-many relationships defined outside of this extension. In fact it's what's recommended upstream: opengeospatial/geopackage#678 (comment)
|
@rouault thanks! Do you think this is appropriate for backporting? |
|
At this stage of 3.8.x, the benefit vs risk is a bit low given than 3.8.5 will probably be the last point release in the 3.8.x series |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading relationships, always read relationships defined using foreign key constraints regardless of whether or not the related tables extension is in use.
The related table extension only permits definition of many-to-many relationships, so there's a strong case for supporting one-to-many relationships defined outside of this extension. In fact it's what's recommended upstream: opengeospatial/geopackage#678 (comment)