Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deps): Update pre-commit hook igorshubovych/markdownlint-cli to v0.43.0 #1249

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 23, 2024

This PR contains the following updates:

Package Type Update Change
igorshubovych/markdownlint-cli repository minor v0.42.0 -> v0.43.0

Note: The pre-commit manager in Renovate is not supported by the pre-commit maintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.


Release Notes

igorshubovych/markdownlint-cli (igorshubovych/markdownlint-cli)

v0.43.0

Compare Source

  • Update markdownlint dependency to 0.36.1
    • Improve MD051
    • Make micromark parser available to custom rules
    • Improve performance
  • Update all dependencies via Dependabot

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/igorshubovych-markdownlint-cli-0.x branch from 71049bd to 1e7fe0f Compare December 24, 2024 21:56
@echoix
Copy link
Member

echoix commented Dec 24, 2024

@ecodiv Would you mind taking a look at the failures here? It seems that there are some trailing whitespaces that would be fixed by pre-commit, on modules that you frequently work on.

If they get fixed, you can merge this PR afterwards.

The real comprehensive fix is to make sure they don't get introduced, with an .editorconfig file that makes the IDEs respect some common configuration. I started to get working in the main repo, but the PRs are still stuck in review. Afterwards, I'll implement the same here, with a common configuration (where possible) to help maintenance.

@echoix
Copy link
Member

echoix commented Dec 25, 2024

There's still some more to fix. If any one else has the opportunity to do it before me, the thing to do is run pre-commit run -a (run on all files), and commit the results.

@ecodiv
Copy link
Contributor

ecodiv commented Dec 25, 2024

I overlooked a few training spaces, corrected that now.

@renovate renovate bot force-pushed the renovate/igorshubovych-markdownlint-cli-0.x branch from 6ee0525 to 71e469f Compare December 25, 2024 16:00
@echoix
Copy link
Member

echoix commented Dec 25, 2024

Thanks for helping out @ecodiv!

Copy link
Contributor Author

renovate bot commented Dec 25, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@echoix echoix merged commit 3b2517a into grass8 Dec 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants