Upgrade Android version #37
Conversation
|
Hey @cpholguera. This seems to be failing checks because the build is failing on the "Sign app APK" step. I believe the keys might be misconfigured, because it builds fine in my fork: jsherm-fwdsec#2 |
|
Hi @jsherm-fwdsec, thanks for letting me know. When I merged your previous PR the Action was successful, so I assumed that the keys config was right. Please take a look here: https://github.com/OWASP/MASTG-Hacking-Playground/actions/runs/3040311391 What do you think? |
|
Yeah it's really odd behaviour if the keys weren't purposely modified but I can't think of any other reason why. Can you possibly try resetting the keys? Check this out: r0adkll/sign-android-release#61 |
There was a problem hiding this comment.
This is great @jsherm-fwdsec, I'll merge and we'll see if the signing works well from master. Thank you very much!
Upgraded Android version to 33, and migrated to AndroidX.
This PR closes #34.