OXDEV-7456: Add mutation to change theme string setting

OXID-eSales · Nov 20, 2023 · 3ac3574 · 3ac3574
1 parent ece7379
commit 3ac3574
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 3 deletions.
diff --git a/src/Setting/Infrastructure/ThemeSettingRepository.php b/src/Setting/Infrastructure/ThemeSettingRepository.php
@@ -142,7 +142,9 @@ public function saveBooleanSetting(ID $name, bool $value, string $themeId): void
 
     public function saveStringSetting(ID $name, string $value, string $themeId): void
     {
-        // TODO: Implement saveStringSetting() method.
+        $value = $this->shopSettingEncoder->encode(FieldType::STRING, $value);
+
+        $this->saveSettingValue($name, $themeId, (string)$value);
     }
 
     public function saveSelectSetting(ID $name, string $value, string $themeId): void

diff --git a/tests/Integration/Infrastructure/ThemeSettingRepositoryTest.php b/tests/Integration/Infrastructure/ThemeSettingRepositoryTest.php
@@ -63,7 +63,7 @@ public function testSaveNotExistingIntegerSetting(): void
     public function testSaveAndGetFloatSetting(): void
     {
         $name = "coolFloatSetting";
-        $eventDispatcher = $this->getEventDispatcherMock("coolFloatSetting");
+        $eventDispatcher = $this->getEventDispatcherMock($name);
         /** @var QueryBuilderFactoryInterface $queryBuilderFactory */
         $queryBuilderFactory = $this->get(QueryBuilderFactoryInterface::class);
 
@@ -100,7 +100,7 @@ public function testSaveNotExistingFloatSetting(): void
     public function testSaveAndGetBooleanSetting(): void
     {
         $name = "coolBooleanSetting";
-        $eventDispatcher = $this->getEventDispatcherMock("coolBooleanSetting");
+        $eventDispatcher = $this->getEventDispatcherMock($name);
         /** @var QueryBuilderFactoryInterface $queryBuilderFactory */
         $queryBuilderFactory = $this->get(QueryBuilderFactoryInterface::class);
 
@@ -134,6 +134,43 @@ public function testSaveNotExistingBooleanSetting(): void
         $repository->saveBooleanSetting(new ID('notExistingSetting'), true, 'awesomeTheme');
     }
 
+    public function testSaveAndGetStringSetting(): void
+    {
+        $name = 'coolBooleanString';
+        $eventDispatcher = $this->getEventDispatcherMock($name);
+        /** @var QueryBuilderFactoryInterface $queryBuilderFactory */
+        $queryBuilderFactory = $this->get(QueryBuilderFactoryInterface::class);
+
+        $repository = $this->getSut(
+            eventDispatcher: $eventDispatcher,
+            queryBuilderFactory: $queryBuilderFactory
+        );
+
+        $this->createThemeSetting(
+            $queryBuilderFactory,
+            $name,
+            FieldType::STRING,
+            'default'
+        );
+
+        $repository->saveStringSetting(new ID($name), 'new value', 'awesomeTheme');
+        $stringResult = $repository->getString(new ID($name), 'awesomeTheme');
+
+        $this->assertSame('new value', $stringResult);
+    }
+
+    public function testSaveNotExistingStringSetting(): void
+    {
+        $eventDispatcher = $this->createMock(EventDispatcherInterface::class);
+        $eventDispatcher->expects($this->never())
+            ->method('dispatch');
+        $repository = $this->getSut(eventDispatcher: $eventDispatcher);
+
+        $this->expectException(NotFound::class);
+        $this->expectExceptionMessage('Configuration "notExistingSetting" was not found for awesomeTheme');
+        $repository->saveStringSetting(new ID('notExistingSetting'), 'new value', 'awesomeTheme');
+    }
+
     private function getSut(
         ?BasicContextInterface $basicContext = null,
         ?EventDispatcherInterface $eventDispatcher = null,

diff --git a/tests/Unit/Infrastructure/ChangeThemeSettingRepositoryTest.php b/tests/Unit/Infrastructure/ChangeThemeSettingRepositoryTest.php
@@ -66,6 +66,23 @@ public function testChangeThemeSettingBoolean(): void
         $repository->saveBooleanSetting($nameID, false, 'awesomeTheme');
     }
 
+    public function testChangeThemeSettingString(): void
+    {
+        $nameID = new ID('stringSetting');
+
+        $settingEncoder = $this->getShopSettingEncoderMock(
+            FieldType::STRING,
+            'default',
+            'default'
+        );
+        $repository = $this->getSut(settingEncoder: $settingEncoder);
+        $repository->expects($this->once())
+            ->method('saveSettingValue')
+            ->with($nameID, 'awesomeTheme', 'default');
+
+        $repository->saveStringSetting($nameID, 'default', 'awesomeTheme');
+    }
+
     public function getShopSettingEncoderMock(
         string $fieldType,
         mixed $decodedValue,