Wait for a minimum amount of time since parent assertion was created to post a new assertion #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to post a new assertion
rauljordan
reviewed
Dec 10, 2024
rauljordan
approved these changes
Dec 10, 2024
|
Would just fix up the default for the time since parent and then can merge |
rauljordan
reviewed
Dec 10, 2024
rauljordan
previously approved these changes
Dec 10, 2024
rauljordan
reviewed
Dec 10, 2024
rauljordan
dismissed
their stale review
Need to think about how it affects overflow assertions
rauljordan
reviewed
Dec 10, 2024
|
Hi @ganeshvanahalli , is the e2e test flakey only on this branch? |
@rauljordan I'm not sure, seems like a bunch of merge commits to main are failing on build and test step, example commit d59df31 https://github.com/OffchainLabs/bold/actions/runs/12354512151/job/34476031390 |
rauljordan
approved these changes
Dec 27, 2024
|
Hi @eljobe PTAL when you are back before merge just to have your approval for overflow assertions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier if assertion manager fails to create an assertion, it'd wait an hour before trying again. This PR fixes this by allowing immediate retries but inside the assertion creation we enable waiting for a minimum amount of time (configurable) since the parent assertion was created.
Corresponding nitro PR- OffchainLabs/nitro#2825
Part of NIT-2961