allow receive fn to return err

OffchainLabs · Dec 20, 2024 · b23e212 · b23e212
1 parent e43a28a
commit b23e212
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/stylus-proc/src/macros/public/types.rs b/stylus-proc/src/macros/public/types.rs
@@ -117,7 +117,7 @@ impl PublicImpl {
                 }
 
                 #[inline(always)]
-                fn receive(storage: &mut S) -> Option<()> {
+                fn receive(storage: &mut S) -> Option<Result<(), Vec<u8>>> {
                     #receive
                 }
             }

diff --git a/stylus-sdk/src/abi/mod.rs b/stylus-sdk/src/abi/mod.rs
@@ -64,7 +64,7 @@ where
     /// Receive functions are always payable, take in no inputs, and return no outputs.
     /// If defined, they will always be called when a transaction does not send any
     /// calldata, regardless of the transaction having a value attached.
-    fn receive(storage: &mut S) -> Option<()>;
+    fn receive(storage: &mut S) -> Option<Result<(), Vec<u8>>>;
 
     /// Called when no receive function is defined.
     /// If no #[fallback] function is defined in the contract, then any transactions that do not
@@ -105,7 +105,10 @@ where
 
     if input.is_empty() {
         console!("no calldata provided");
-        if R::receive(&mut storage).is_some() {
+        if let Some(res) = R::receive(&mut storage) {
+            if let Err(e) = res {
+                return Err(e);
+            }
             return Ok(Vec::new());
         }
         // Try fallback function with no inputs if defined.