Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mini alloc edits #89

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Mini alloc edits #89

merged 2 commits into from
Dec 2, 2023

Conversation

rachel-bousfield
Copy link
Contributor

This PR includes some suggested changes to mini-alloc based on review and performance numbers.

Notably, the crate now

  • defaults to WeeAlloc for x86 and ARM. Though this wasn't what we originality considered, it's a bit safer and minimizes our scope and SLA.
  • Removes an overflow scenario.
  • Uses fewer branches and other heavy instructions.

We should still add expanded tests for this

@mikebenfield mikebenfield merged commit eba4d66 into mini-alloc3 Dec 2, 2023
4 of 10 checks passed
@rachel-bousfield rachel-bousfield deleted the mini-alloc-edits branch December 2, 2023 07:51
@rachel-bousfield rachel-bousfield mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachel-bousfield @mikebenfield