Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fx-core): split scaffold question models #12852

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

jayzhang
Copy link
Member

@jayzhang jayzhang commented Dec 5, 2024

No description provided.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 28.47896% with 221 lines in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (fd8dfe6) to head (80e718d).
Report is 68 commits behind head on dev.

Files with missing lines Patch % Lines
...ackages/fx-core/src/question/refactor/createVsc.ts 9.33% 204 Missing ⚠️
...component/generator/templates/templateGenerator.ts 38.88% 11 Missing ⚠️
packages/fx-core/src/ui/visitor.ts 64.28% 1 Missing and 4 partials ⚠️
packages/cli/src/userInteraction.ts 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12852      +/-   ##
==========================================
- Coverage   90.05%   89.51%   -0.55%     
==========================================
  Files         577      580       +3     
  Lines       34327    34704     +377     
  Branches     6829     6805      -24     
==========================================
+ Hits        30914    31064     +150     
- Misses       1507     1724     +217     
- Partials     1906     1916      +10     
Files with missing lines Coverage Δ
packages/fx-core/src/question/constants.ts 96.02% <100.00%> (+<0.01%) ⬆️
packages/fx-core/src/question/create.ts 90.57% <100.00%> (+0.04%) ⬆️
packages/fx-core/src/question/templates.ts 100.00% <100.00%> (ø)
packages/cli/src/userInteraction.ts 86.95% <80.00%> (ø)
packages/fx-core/src/ui/visitor.ts 86.19% <64.28%> (-1.63%) ⬇️
...component/generator/templates/templateGenerator.ts 77.27% <38.88%> (-14.89%) ⬇️
...ackages/fx-core/src/question/refactor/createVsc.ts 9.33% <9.33%> (ø)

... and 20 files with indirect coverage changes

jayzhang and others added 2 commits December 5, 2024 11:07
* fix: update schema version

* fix: schema version

* fix bug: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/30232352

* feat: turn on TCE feature flag

refactor: remove view to avoid loading page is incorrect

refactor: more

* fix(kiota): fix spec path when generating auth actions (#12764)

* docs: update changelog for hotfix

* docs: add changelog for ghcp prerelease

* fix(oauth): add app id uri in oauth register action

* fix: fix comment

* test: add ut

* refactor: de-capitalize string

* fix: kill process silently (#12790)

* fix: silent kill process

* fix: wait some time before recheck port

* fix: slient timeout

* fix: improve telemetry when user cancel teminating processes

* fix: add global deine in vite confg

* fix: sso oauth registration update issue

* fix: update test case to make codecov happy

* perf: align yaml.schema.json file

* fix: kill process cancel

* build: rollback rc version

* refactor: 1.7 schema

* refactor: 1.7 schema

* fix: add Application ID URL

* refactor: reuse v1.7 schema

* fix: aad update issue

* fix: improve terminate process error handling (#12811)

* fix: improve terminate process error handling

* fix: improve terminate process error handling

* test: ut

* test: ut

* test: ut

* fix(vsc): sideloading error messages (#12797)

* fix(vsc): sideloading error messages

* fix: unit test

* fix: ut

* fix: ut timer

* fix(vsc): update aka link

* fix: button action

* test: fix e2e test case get error pkg (#12814)

* build: rollback rc version (#12806)

* perf(da): allow multiple auth when scaffolding (#12812)

* perf(da): allow multiple auth when scaffolding

* perf: update test cases

---------

Co-authored-by: rentu <rentu>

* test: update temp version with alpha (#12822)

* test: add chatdata py real aikey validation (#12820)

* test: add chatdata py real aikey validation


---------

Co-authored-by: Ivan_Chen <[email protected]>

* test: sdk e2e update (#12829)

* test: fix e2e test

* test: update tests

* docs: update contributing guide

---------

Co-authored-by: Yiqing Zhao <[email protected]>

* feat: agent deep link (#12825)

* feat: update the launch url for declarative agents (#12832)

* perf(ai-generator): add prompt suggestions (#12838)

Co-authored-by: rentu <rentu>

* feat: upgrade templates (#12815)

* test: update msgsa cli (#12839)

* fix: update code owners (#12836)

* test: clean up api key registration (#12840)

* fix: github copilot only shown if non stable release (#12843)

* fix: github copilot only shown if non stable release

* fix: github copilot only shown if non stable release

* fix: github copilot only shown if non stable release

* fix: allow daily build

* feat: support tenant parameter for m365 & azure browser login in cli (#12837)

* feat: support tenant parameter for azure cli browser login

* feat: m365 cli login accept tenant parameter

* feat: multi-tenant support for cli m365 login

* feat: fallback to unique name and fix bugs

* fix: switch tenant before list sub

* refactor: remove code flow tenant login

* refactor: remove unused codes

* test: add ut to raise code coverage

* test: add ut

* test: add ut

* test: fix failure ui test case (#12841)

* test: update sample large notification case

* test: skip warning during debug session

* test: update debug random os

* test: update dashboard sample

---------

Co-authored-by: Ivan_Chen <[email protected]>

* ci: local commit (#12844)

* fix: local commit

* fix: local commit

* fix: local commit

* perf(spec-parser): update to support custom header api key (#12846)

* perf(spec-parser): update to support custom header api key

* fix: test case

---------

Co-authored-by: rentu <rentu>

* ci: create issue for hotfix that user need to cherry-pick to other branches (#12835)

* ci: create issue for hotfix

* ci: update

* ci: add issue labeled action to create the ado ticket

* feat: display tenant name when user specify tenant id (#12845)

* feat: display tenant name when user specify tenant id

* test: fix ut

* test: add ut

* test: add ut

* feat: troubleshoot UI (#12851)

* feat: command

* feat: selected text troubleshot

* refactor: condition

* feat: troubleshoot error

* test: ut

* test: ut

* refactor: remove unused change

* test: update bot validation (#12854)

Co-authored-by: Ivan_Chen <[email protected]>

* refactor: attach tenant id parameter in switch tenant event (#12855)

* refactor: feature flag cleanup (#12857)

* feat: update create new project UI (#12847)

* feat: update create new project UI

* ci: update the cherry-pick workflow actions (#12860)

* test: bot notify

* ci: update

* ci: update the cherry pick workflow

* refactor: string update (#12861)

* refactor: string update

* refactor: update string

* fix(da): remove prompt suggestion in ai-plugin, fix registration id mismatch (#12859)

Co-authored-by: rentu <rentu>

* test: add e2e test for multi-tenant feature (#12858)

* test: add e2e test for multi-tenant feature

* test: update test case id

* fix: update m365 tenant name

* perf: notify user to output panel (#12862)

* perf: notify user to output panel

* perf: notify user to output panel

* test: ut

* refactor: telemetry

* refactor: string update (#12864)

* fix(spec-parser): graph spec hang issue, 2XX not support issue (#12865)

Co-authored-by: rentu <rentu>

* ci: update ci policy for release and dev (#12869)

* refactor: notification order (#12868)

* refactor: order

* refactor: some delay and notification msg rather than btn

* test: ut

* test: ut

* build(deps): bump actions/download-artifact in /.github/workflows (#12327)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* perf(da): update scaffolding for api key custom header (#12853)

Co-authored-by: rentu <rentu>

* fix: update introduction.txt to comply with latest Copilot security policies

* fix: remove empty command in link unfurling templates (#12871)

* fix: use TeamsAdapter in custom copilot templates (#12873)

* feat: update walkthrough (#12863)

* feat: update walkthrough

* Updated for https://dev.azure.com/devdiv/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_build?definitionId=23438 by using baselines generated in https://dev.azure.com/devdiv/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_build/results?buildId=10130580 (#12300)

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>

* refactor: Localized file check-in by OneLocBuild Task: Build definition ID 23438: Build ID 10123018 (#12293)

* ci: add localization pipeline yml file

* fix: add targetpath

* fix: enable persistCredentials

* fix: feed name

* fix: feed

* fix: feed

* Localized file check-in by OneLocBuild Task: Build definition ID 23438: Build ID 10122952

* ci: upgrade upload and download artifacts github action to v4 (#12877)

* refactor: get started (#12878)

* chore: update the cherry-pick condition for release (#12890)

* chore: update the cherry-pick condition for release

* ci: update

* ci: update cherrypick condition (#12894)

* ci: lint-pr check sense condition update (#12895)

* fix: wording and welcome page (#12879)

* refactor: update github account mapping (#12899)

* feat: support env variables in localization.json (#12889)

* feat: support env variables in localization.json

* test: add ut

* test: fix ut

* test: add ut

* fix: load tenant id when getting user login status (#12872)

* refactor: show three buttons at most (#12900)

* refactor: show three buttons at most

* test: ut

* ci: update the script for cherry-pick with trim space (#12906)

* refactor: update teamsAdapter (#12902)

* test: update adding app (#12911)

* docs: merge changelog back to dev

* refactor: update yml (#12914)

* test: fix auto test issue due to ui change (#12916)

* test: rename sample hello world tab outlook add in

* test: delete duplicated case

---------

Co-authored-by: ivanchen <[email protected]>
Co-authored-by: 陈斯苑 <[email protected]>

* test: update new project (#12919)

* task 30506176: Add validation steps back to CEA templates (#12915)

* Update launch url to open CEA in Copilot directly (#12917)

* feat: update fx-core to support new Microsoft Entra schema (#12918)

* feat: update fx-core to support new Microsoft Entra shema

* fix: add missing test material

* fix: update test cases

* fix: update test cases

---------

Co-authored-by: rentu <rentu>

* refactor: update (#12922)

* fix: fix bot-me search limitations (#12925)

* refactor: update greeting action (#12927)

* feat: add convert aad manifest to new schema in fx-core (#12928)

* feat: add convert aad manifest to new schema in fx-core

* perf: update message

* fix: message

---------

Co-authored-by: rentu <rentu>

* feat: copilot plugin debugger (#12876)

* feat: copilot plugin debugger initial changes

* fix: compile error

* feat: clean up cdp

* feat: use short telemetry event name

* feat: collect and clean cdp clients

* feat: telemetry + error handling + feature flag + templates

* fix: connection check

* refactor: revert telemetry event

* refactor: clean

* refactor: clean

* refactor: clean

* test: ut

* feat: version

* feat: revert

* fix: isM365CopilotChatDebugSession

* test: ut

* test: ut

* refactor: update ui to success driven

* test: ut

* test: ut

* test: ut for cdpClient

* fix: ut

* fix: m365 compabible

* fix: both url works

* fix: ut

* fix: log

* feat: support multiple api debug sessions

* test: add unit tests for copilot debug log output

* test: ut

* test: ut

* test: ut

---------

Co-authored-by: samwelkanda <[email protected]>

* feat: add validation steps back to Python CEA templates (#12933)

* feat: update launch url in Python templates to open CEA in Copilot directly (#12934)

* test: use azure openai key for daily release (#12924)

* feat: notify if AAD manifest is already in new schema (#12935)

Co-authored-by: rentu <rentu>

* test: revert sample tab outlook name change (#12937)

* test: revert sample tab outlook name change

---------

Co-authored-by: ivan chen <[email protected]>

* test: update to open a sample view (#12943)

* test: update to open a sample view

* test: update to create outlook add in

* fix: wxp template

* fix: wxpo

* fix: questions

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Hui Miao <[email protected]>
Co-authored-by: Qinghui Meng <[email protected]>
Co-authored-by: MSFT-yiz <[email protected]>
Co-authored-by: Yuqi Zhou <[email protected]>
Co-authored-by: Bowen Song <[email protected]>
Co-authored-by: Junjie Li <[email protected]>
Co-authored-by: Wei Shen <[email protected]>
Co-authored-by: Eric Chen <[email protected]>
Co-authored-by: Yuqi Zhou <[email protected]>
Co-authored-by: Yimin-Jin <[email protected]>
Co-authored-by: rentu <rentu>
Co-authored-by: rentu <[email protected]>
Co-authored-by: Fan Hu <[email protected]>
Co-authored-by: Ning Tang <[email protected]>
Co-authored-by: wenyt <[email protected]>
Co-authored-by: FanH <[email protected]>
Co-authored-by: Siyuan Chen <[email protected]>
Co-authored-by: Ivan_Chen <[email protected]>
Co-authored-by: Yiqing Zhao <[email protected]>
Co-authored-by: Yiqing Zhao <[email protected]>
Co-authored-by: anchenyi <[email protected]>
Co-authored-by: Annefch <[email protected]>
Co-authored-by: Helly Zhang <[email protected]>
Co-authored-by: HuihuiWu-Microsoft <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yimin-Jin <[email protected]>
Co-authored-by: yukun-dong <[email protected]>
Co-authored-by: Kuojian Lu <[email protected]>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Zhaofeng Xu <[email protected]>
Co-authored-by: 陈斯苑 <[email protected]>
Co-authored-by: samwelkanda <[email protected]>
Co-authored-by: frankqianms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant