Skip to content

Commit

Permalink
Remove HttpOnly flag from lang cookie
Browse files Browse the repository at this point in the history
Other non-PHP components use the lang cookie in their Javascript,
setting the flag on this global cookie would mess up their operations.

Thanks @tveijen voor pointing this out!

See: OpenConext/OpenConext-deploy#320 (comment)
See: #1056
  • Loading branch information
MKodde committed Jan 11, 2021
1 parent 0fb7ab1 commit 62bcd8e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/config/parameters.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ parameters:
cookie.secure: true
cookie.locale.domain: .vm.openconext.org
cookie.locale.expiry: 5184000
cookie.locale.http_only: true
cookie.locale.http_only: false
cookie.locale.secure: true

## UI settings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
use RuntimeException;
use SAML2\XML\mdui\Common;
use SAML2\XML\shibmd\Scope;
use function count;

/**
* Mink-enabled context.
Expand Down Expand Up @@ -168,8 +169,9 @@ public function iShouldSeeLinksOnTheFrontPage($expectedNumberOfLinks)
if (count($anchors) != $expectedNumberOfLinks) {
throw new ExpectationException(
sprintf(
'The expected amount (%d) of metadata links could not be found on the page',
$expectedNumberOfLinks
'The expected amount (%d) of metadata links could not be found on the page, actually found "%d"',
$expectedNumberOfLinks,
count($anchors)
),
$this->getSession()
);
Expand Down

0 comments on commit 62bcd8e

Please sign in to comment.