Main (3.5.1) to dev merge #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… typos in comments
This resolves an issue where the blade pitch would drift during simulations with relatively small time steps (0.0001s) if no modules were actively resetting the value at each solution step (eg. CompServo=0). This was especially problematic when InterpOrder=2. By checking if the inputs are equal and setting the output directly, the error is eliminated.
FF: fix plane output for wakedynamics
The indentation in NWTC_Num was accidentally changed during a copy/pase in OpenFAST#1731. This restores the correct indentation while maintaining the relevant changes to avoid merge conflicts.
The reference frame is now moving. All values from p%GlbRot, p%Glb_crv, and p%GlbPos are now stored as otherstates and get updated at the end of an updatestates routine. Additional logic and data handling was changed within BD: - UpdateStates starts with the initial root position at T, and `q` and `dqdt` are relative to this position/orientation. - once UpdateStates converges, the `q` and `dqdt` states are updated to the root position/orientat at T+dt - Output calculations (mesh and channel outputs) have been modified - Inputs are slightly modified as well During Init, the values in `q` and `dqdt` are updated twice. The first time is relative to the reference frame for the meshes, and the second time for the mesh reference frame + displacements.
may have positions in mesh partially correct. Rotations appear too far though, so something wrong with rotation handling
This commit specifies Python_ROOT_DIR for each github action since each Job may have a different version of Python and a different path to the executable. By specifying Python_ROOT_DIR each Job should get a valid path.
See if 5MW_OC4Semi_Linear will run faster when built using OpenBLAS
Small modification for the linear spring approach in MAP++. This modification allows to study conventional catenary systems as well as lines that have the anchor point above the fairlead connection. This modification solves the problems reported here for the linear spring approach: OpenFAST#1750
Still has a free energy problem.
Trying to resolve issue with regression test failure when it was previously passing
This reduces the number of parallel linearization regression tests in GH actions in an attempt to keep the actions from failing
When using the Intel compiler, summing along a dimension of an array creates a temporary copy which can be very large for 3D grid flow fields. The Intel compiler tries to allocate this temporary array on the stack, but it's too large and fails.
InflowWind Flow Field fails to calculate AvgVel for large wind files when using Intel Compiler
Updated the MD registry and types file
- fix file name for AeroDyn_Inflow_Registry.txt in the visual studio project files - also add `SAVE` attribute to avoid compiler warnings
Minor fixes for ADI in Visual Studio project files
VS-build updates for rc-3.5.1 and other minor updates
Release 3.5.1
This is an intermediate branch for resolving merge conflicts.
andrew-platt
added
Module: HydroDyn
Module: MoorDyn
FAST.Farm
Feature: MHK
Some compatibility updates were made in main for deprecation warnings on GH actions
deslaughter
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge
Feature or improvement description
There are a few minor bugfixes in the main branch (3.5.1 release) that have not been included in
devyet. These included the new visualization for MoorDyn and HydroDyn, MoorDyn bugfixes, a few minor bug fixes (some already in dev), and release related updates (changelog etc).Related issue, if one exists
None
Impacted areas of the software
There was also a small change added for the AWAE module -- the MHK flag is now explicitly set to 0 for the
Mod_AmbWind=3case. This had not previously been set, so it used whatever garbage was in memory and could lead to IfW failures for wind above ground if the MHK flag read a non-zero value from memory.Additional supporting information
Test results, if applicable
A few tests changed very slightly.