Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HD: Remove extra copy of WaveStMod from Morison #1883

Merged

Conversation

bjonkman
Copy link
Contributor

Feature or improvement description
One more copy of WaveStMod was still in the code, so I removed it. The previous PR #1864 missed this one, so it would have been uninitialized and broken some wave stretching code.

Related issue, if one exists
#1864

Impacted areas of the software
Wave stretching in Morison (HydroDyn)

Test results, if applicable
There are no tests for wave stretching.

@andrew-platt andrew-platt self-assigned this Nov 18, 2023
@andrew-platt andrew-platt added Module: HydroDyn Module: SeaState SeaState module for wave data generation labels Nov 18, 2023
@andrew-platt andrew-platt added this to the v4.0.0 milestone Nov 18, 2023
@andrew-platt andrew-platt merged commit 1f12756 into OpenFAST:dev-unstable-pointers Nov 18, 2023
21 checks passed
@bjonkman bjonkman deleted the f/WaveField_cleanup branch November 27, 2023 18:57
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: HydroDyn Module: SeaState SeaState module for wave data generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants