Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this pull request can be merged.
Feature or improvement description
SubDyn can output in the summary file (
SumPrint = 1
) the cosine matrices (OutCOSM = True
).In the summary file, the direction cosine for a spring element is not properly written. The summary file looks as:
As can be observed, the summary file shows only zeros for the spring element. This is because the
subroutine OutSummary
tries to get the direction cosine based on the joint 1 and joint 2 of the member (and joint 1 and joint 2 are coincident for springs). In this PR, thesubroutine OutSummary
has been modified to properly account for the spring element (and arbitrary beams in the future).However, I believe that if the user defines a given direction cosine for a circular beam, the
subroutine GetDirCos
will also compute the direction cosine based on joint 1 and joint 2, effectively overwriting whatever the user provided as input.Impacted areas of the software
SubDyn summary file.
Test results, if applicable
Proper summary file: