Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubDyn summary file: fixes #1911

Merged
merged 2 commits into from
Dec 4, 2023
Merged

SubDyn summary file: fixes #1911

merged 2 commits into from
Dec 4, 2023

Conversation

RBergua
Copy link
Contributor

@RBergua RBergua commented Dec 1, 2023

I believe this pull request can be merged.

Feature or improvement description
SubDyn can output in the summary file (SumPrint = 1) the cosine matrices (OutCOSM = True).

In the summary file, the direction cosine for a spring element is not properly written. The summary file looks as:
Wrong

As can be observed, the summary file shows only zeros for the spring element. This is because the subroutine OutSummary tries to get the direction cosine based on the joint 1 and joint 2 of the member (and joint 1 and joint 2 are coincident for springs). In this PR, the subroutine OutSummary has been modified to properly account for the spring element (and arbitrary beams in the future).

However, I believe that if the user defines a given direction cosine for a circular beam, the subroutine GetDirCos will also compute the direction cosine based on joint 1 and joint 2, effectively overwriting whatever the user provided as input.

Impacted areas of the software
SubDyn summary file.

Test results, if applicable
Proper summary file:
Right

Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change out the tab characters for spaces? Otherwise I approve

modules/subdyn/src/SubDyn.f90 Outdated Show resolved Hide resolved
modules/subdyn/src/SubDyn.f90 Outdated Show resolved Hide resolved
@andrew-platt andrew-platt self-assigned this Dec 3, 2023
@andrew-platt andrew-platt added this to the v4.0.0 milestone Dec 3, 2023
@andrew-platt
Copy link
Collaborator

andrew-platt commented Dec 3, 2023

For @andrew-platt:

  • Check that readthedocs renders when this PR is merged (updates to webhook might have broken the intergration)

@andrew-platt andrew-platt merged commit 88e18ed into OpenFAST:dev Dec 4, 2023
21 checks passed
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants