Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADsk: correction to disk average velocity equations #2575

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented Dec 19, 2024

Merge after 3.5.5 cross merge (rebase then).

Feature or improvement description
AeroDisk calculations were using an incorrect set of points for the DiskAvgVel calculations. The set of points used in the previous calculation was aligned with the hub axis instead of perpendicular to the hub axis.

Related issue, if one exists
See PR #2532 for details

Impacted areas of the software
AeroDisk only

Additional supporting information
Merge this after cross-merging main into dev after the 3.5.5 release.

Test results, if applicable
Test results will change slightly with this change.

  • r-test merge required

@andrew-platt andrew-platt added the Module: AeroDisk Disk actuator aerodynamics model label Dec 19, 2024
@andrew-platt andrew-platt added this to the v4.0.0 milestone Dec 19, 2024
@andrew-platt
Copy link
Collaborator Author

andrew-platt commented Dec 22, 2024

Some regression tests with OpenFAST changed significantly:

5MW_Land_DLL_WTurb_ADsk

Screenshot 2024-12-22 at 1 32 22 PM
Figure1: Disk average wind velocity has changed significantly as the sampling area is now in the rotor disk plane. This gives slightly lower, but smoother, average wind speeds than when the disk averaging points were located in the wrong plane (circle lying in the rotating hub X-Y plane, so it was spinning like a circular egg beater in front of the rotor which gave the periodic spikes).

Screenshot 2024-12-22 at 2 10 19 PM
Figure 2: blade pitch changes as rotor loads change. The new results track slightly better than the original.

Screenshot 2024-12-22 at 2 11 03 PM
Figure 3: GenPwr comparison with 5MW_Land_DLL_WTurb case. This is closer to the expected full OpenFAST simulation with AeroDyn.

5MW_Land_DLL_WTurb_ADsk_SED

Screenshot 2024-12-22 at 2 18 51 PM
Figure 1: Disk average wind speed changes, similar to above case

Screenshot 2024-12-22 at 2 19 36 PM
Figure 2: GenPwr is closer to the full OpenFAST simulation with AeroDyn than before.

TSinflowADskSED

Similar differences were noted on the second turbine in this case (only the main FAST.Farm.out file is compared). The wake calculations are not as affected by the change in the disk average wind calculations.

Screenshot 2024-12-22 at 2 26 08 PM
Figure 1: Slight changes are noted in the wind velocity at the second rotor (note this is at the FF timestep).

@andrew-platt andrew-platt merged commit abf5938 into OpenFAST:dev Dec 23, 2024
21 checks passed
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
@andrew-platt andrew-platt deleted the b/ADsk_DiskAvgVel branch January 2, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: AeroDisk Disk actuator aerodynamics model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants