Merge v3.5.5 to dev #2580
Merged
Merge v3.5.5 to dev #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory for the ftnmod folder which caused it to be in the wrong place when importing OpenFAST as a library in AMR-Wind
CMAKE_INSTALL_PREFIX was incorrectly being prepended to the install d…
…mpilation to fail when using the Intel oneAPI 2024.1.0 compiler
Remove $OMP directives from AeroDyn_Inflow due to Intel compiler bug
change to tag tracking
repository name must be lowercase
Docker: typo was preventing docker build upload to GH
When OLAF was used with the AeroDyn Driver compiled with ifx (IFX) 2023.2.0 20230622 (release only), there would be a segmentation fault when SetInputsForFVW was called. The root issue was that passing an array of `u` as `(/u/)` doesn't work correctly with this compiler. So to work around this, the SetInputsForFVW routine was reworked to only operate on a single `u`. In my opinion this is a hack of a solution to accomodate a compiler bug.
AD bugfix: Segmentation fault with ifx
Neither the C-bindings nor AD driver could use the BoxExceedAllow option with OLAF
ADI bugfix: BoxExceed was not enabled for OLAF with ADI
This was introduced in PR #2518. The result was that anytime the driver was used with OLAF, all points were allowed outside the box, not just the wake as intended.
IfW defaults this to -1, so if OLAF is used it would simply pass -1 for the index rather than the correct location from the AD_BoxExceedPointsIdx routine.
bugfix: with OLAF, BoxExceed was allowed for all points
The calculations for the rotor disk average wind speed use a set of point projected on the disk perpindular to the hub at ~0.7 rotor radius in the hub YZ plane. However, the indices for this calculation were incorrect and projected the points onto disk in the hub XY plane. This was discovered after one of the cases used in the curled wake paper failed to run correctly with 3.5.4 for a turbine very close to the back edge of the high resolution domain. Also added some additional information about the location of points causing outside box bound errors.
bugfix: IfW rotor points for disk average incorrect
Co-authored-by: Derek Slaughter <[email protected]>
…AMR-Wind/Nalu-Wind)
FAST.Farm: increase number of output planes to 999
Allow ParseVar to parse file paths containing spaces.
Add `!$OMP critical` directives around some GetNewUnit/Open*File calls
…openfast-cpp from the OpenFAST library C++ driver
Create BUILD_OPENFAST_LIB_DRIVER flag for the OpenFAST C++ Library Interface (not CFD)
Disable LiDAR in IfW at FAST.Farm level
Release 3.5.5
`!$ OMP critical` directives were added to all other modules in the 3.5.5 updates, but new modules don't include these
deslaughter
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Several improvements from release 3.5.4 have not been merged into dev yet
Related issue, if one exists
Release 3.5.4: https://github.com/OpenFAST/openfast/releases/tag/v3.5.4
Impacted areas of the software
Only areas impacted by 3.5.4
Additional supporting information
3.5.5 included a few bugfixes that conflict with the current
devbranch. So we are using the intermediary branch ofm/3.5.5_to_devto sort out any differences.Test results, if applicable
There may be very small changes in a few cases due to updates in the disk averaging method. See the companion r-test branch and pull request.
r-test/dev