Modernize GH Actions

[JostMigenda]

• Update versions of various actions (removes warnings/errors due to deprecated/unsupported versions)
• Update/remove arguments to some actions, where new versions require it
• Update gcc, g++ versions under ubuntu-20.04

[github-actions]

⚡ Code Analysis Results ⚡

🔴 Cppcheck found 18 issues! Click here to see details.

CemrgApp/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp

Lines 1813 to 1818 in 466344b

	scalars = vtkFloatArray::SafeDownCast(surface->GetVtkPolyData()->GetCellData()->GetScalars());
	numObjects = surface->GetVtkPolyData()->GetNumberOfCells();
	} else{
	// surface->GetVtkPolyData()->GetCellData()->SetActiveScalars(fieldName.toStdString().c_str());
	scalars = vtkFloatArray::SafeDownCast(surface->GetVtkPolyData()->GetCellData()->GetScalars());
	numObjects = surface->GetVtkPolyData()->GetNumberOfCells();

!Line: 1813 - style: Redundant initialization for 'scalars'. The initialized value is overwritten before it is read. [redundantInitialization]

CemrgApp/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp

Lines 1806 to 1811 in 466344b

	vtkFloatArray *scalars = vtkFloatArray::New();
	vtkIdType numObjects;
	std::cout << "fieldName: " << fieldName.toStdString() << '\n';
	if (isElem){

!Line: 1806 - note: scalars is initialized

CemrgApp/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp

Lines 1813 to 1818 in 466344b

	scalars = vtkFloatArray::SafeDownCast(surface->GetVtkPolyData()->GetCellData()->GetScalars());
	numObjects = surface->GetVtkPolyData()->GetNumberOfCells();
	} else{
	// surface->GetVtkPolyData()->GetCellData()->SetActiveScalars(fieldName.toStdString().c_str());
	scalars = vtkFloatArray::SafeDownCast(surface->GetVtkPolyData()->GetCellData()->GetScalars());
	numObjects = surface->GetVtkPolyData()->GetNumberOfCells();

!Line: 1813 - note: scalars is overwritten

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.h

Lines 55 to 60 in 466344b

	class AtrialFibresClipperView : public QmitkAbstractView {
	// this is needed for all Qt objects that should have a Qt meta-object
	// (everything that derives from QObject and wants to have signal/slots)
	Q_OBJECT

!Line: 55 - style: The class 'AtrialFibresClipperView' does not have a constructor although it has private member variables. [noConstructor]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.h

Lines 66 to 71 in 466344b

	class AtrialFibresView : public QmitkAbstractView {
	// this is needed for all Qt objects that should have a Qt meta-object
	// (everything that derives from QObject and wants to have signal/slots)
	Q_OBJECT

!Line: 66 - style: The class 'AtrialFibresView' does not have a constructor although it has private member variables. [noConstructor]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp

Lines 450 to 455 in 466344b

	radii = vtkDoubleArray::SafeDownCast(line->GetPointData()->GetArray("MaximumInscribedSphereRadius"));
	double adjust = ctrPlane->GetRadius() / radii->GetValue(position);
	//Adjust highlighted clipper
	for (unsigned int i=0; i<clipperActors.size(); i++)
	clipperActors.at(i)->GetProperty()->SetOpacity(i==(unsigned)index ? 1.0 : 0.1);

!Line: 450 - style: Redundant initialization for 'radii'. The initialized value is overwritten before it is read. [redundantInitialization]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp

Lines 449 to 454 in 466344b

	vtkSmartPointer<vtkDoubleArray> radii = vtkSmartPointer<vtkDoubleArray>::New();
	radii = vtkDoubleArray::SafeDownCast(line->GetPointData()->GetArray("MaximumInscribedSphereRadius"));
	double adjust = ctrPlane->GetRadius() / radii->GetValue(position);
	//Adjust highlighted clipper
	for (unsigned int i=0; i<clipperActors.size(); i++)

!Line: 449 - note: radii is initialized

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp

Lines 450 to 455 in 466344b

	radii = vtkDoubleArray::SafeDownCast(line->GetPointData()->GetArray("MaximumInscribedSphereRadius"));
	double adjust = ctrPlane->GetRadius() / radii->GetValue(position);
	//Adjust highlighted clipper
	for (unsigned int i=0; i<clipperActors.size(); i++)
	clipperActors.at(i)->GetProperty()->SetOpacity(i==(unsigned)index ? 1.0 : 0.1);

!Line: 450 - note: radii is overwritten

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.h

Lines 53 to 58 in 466344b

	class AtrialFibresLandmarksView : public QmitkAbstractView {
	// this is needed for all Qt objects that should have a Qt meta-object
	// (everything that derives from QObject and wants to have signal/slots)
	Q_OBJECT

!Line: 53 - style: The class 'AtrialFibresLandmarksView' does not have a constructor although it has private member variables. [noConstructor]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.cpp

Lines 392 to 397 in 466344b

	double distance;
	int pickedSeedId = -1;
	double minDistance = 1E10;
	for (int i=0; i<pickedCellPointIds->GetNumberOfIds(); i++) {
	distance = vtkMath::Distance2BetweenPoints(
	pickPosition, surface->GetVtkPolyData()->GetPoint(pickedCellPointIds->GetId(i)));

!Line: 392 - style: The scope of the variable 'distance' can be reduced. [variableScope]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresVisualiseView.h

Lines 50 to 55 in 466344b

	class AtrialFibresVisualiseView : public QmitkAbstractView {
	// this is needed for all Qt objects that should have a Qt meta-object
	// (everything that derives from QObject and wants to have signal/slots)
	Q_OBJECT

!Line: 50 - style: The class 'AtrialFibresVisualiseView' does not have a constructor although it has private member variables. [noConstructor]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 1795 to 1800 in 466344b

	if(!userInputAccepted){
	QDialog* inputs = new QDialog(0,0);
	m_UIEditLabels.setupUi(inputs);
	connect(m_UIEditLabels.buttonBox, SIGNAL(accepted()), inputs, SLOT(accept()));
	connect(m_UIEditLabels.buttonBox, SIGNAL(rejected()), inputs, SLOT(reject()));
	std::cout << "WHICH ATRIUM: " << uac_whichAtrium.toStdString() << '\n';

!Line: 1795 - style: Condition '!userInputAccepted' is always true [knownConditionTrueFalse]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 1793 to 1798 in 466344b

	bool userInputAccepted=false;
	if(!userInputAccepted){
	QDialog* inputs = new QDialog(0,0);
	m_UIEditLabels.setupUi(inputs);
	connect(m_UIEditLabels.buttonBox, SIGNAL(accepted()), inputs, SLOT(accept()));

!Line: 1793 - note: Assignment 'userInputAccepted=false', assigned value is 0

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 1795 to 1800 in 466344b

	if(!userInputAccepted){
	QDialog* inputs = new QDialog(0,0);
	m_UIEditLabels.setupUi(inputs);
	connect(m_UIEditLabels.buttonBox, SIGNAL(accepted()), inputs, SLOT(accept()));
	connect(m_UIEditLabels.buttonBox, SIGNAL(rejected()), inputs, SLOT(reject()));
	std::cout << "WHICH ATRIUM: " << uac_whichAtrium.toStdString() << '\n';

!Line: 1795 - note: Condition '!userInputAccepted' is always true

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 2340 to 2345 in 466344b

	segImage = atrium->LoadImage(segRegPath);
	resultString = segRegPath;
	tagName += "-reg";
	SetLgeAnalysis(true);

!Line: 2340 - style: Variable 'segImage' is assigned a value that is never used. [unreadVariable]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 193 to 198 in 466344b

	reply1 = Ask("Question", "Use alternative DICOM reader?");
	#endif
	if (reply1 == QMessageBox::Yes) {
	QString dicomFolder = QFileDialog::getExistingDirectory(NULL, "Open folder with DICOMs.", mitk::IOUtil::GetProgramPath().c_str(), QFileDialog::ShowDirsOnly|QFileDialog::DontUseNativeDialog);

!Line: 193 - style: Redundant initialization for 'reply1'. The initialized value is overwritten before it is read. [redundantInitialization]

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 190 to 195 in 466344b

	int reply1 = QMessageBox::No;
	#if defined(__APPLE__)
	MITK_INFO << "Ask user about alternative DICOM reader";
	reply1 = Ask("Question", "Use alternative DICOM reader?");
	#endif

!Line: 190 - note: reply1 is initialized

CemrgApp/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp

Lines 193 to 198 in 466344b

	reply1 = Ask("Question", "Use alternative DICOM reader?");
	#endif
	if (reply1 == QMessageBox::Yes) {
	QString dicomFolder = QFileDialog::getExistingDirectory(NULL, "Open folder with DICOMs.", mitk::IOUtil::GetProgramPath().c_str(), QFileDialog::ShowDirsOnly|QFileDialog::DontUseNativeDialog);

!Line: 193 - note: reply1 is overwritten

[JostMigenda]

The test action runs much farther now, which is nice to see; but the build step still fails with some references to gcc-6 and g++-6, even though I’ve eliminated those from all .yml files. So I’m not quite sure where that comes … unless it is in the precompiled Build folder that it’s downloading in the first step? 🤔

On a separate note: I notice that test.yml is currently set to run on: [push, pull_request]; which means it runs twice when I push a new commit to an open PR, which is wasteful. I’d therefore suggest changing it to only run on PRs?

[alonsoJASL]

The test action runs much farther now, which is nice to see; but the build step still fails with some references to gcc-6 and g++-6, even though I’ve eliminated those from all .yml files. So I’m not quite sure where that comes … unless it is in the precompiled Build folder that it’s downloading in the first step? 🤔

On a separate note: I notice that test.yml is currently set to run on: [push, pull_request]; which means it runs twice when I push a new commit to an open PR, which is wasteful. I’d therefore suggest changing it to only run on PRs?

Thank you Jost, these are great updates.

I agree that, as you mention, the references to older gcc versions would come from the prebuild folders downloaded. The solution would be to make these for the right versions. So, one in macOS, one in Ubuntu and one in Windows. These prebuild folders would be generated once we confirm the build instructions. So that's on my plate at the moment.

I'll accept the merge and we can pause till I provide the build folders. A question, we would need an intel mac and an arm mac prebuild folder, in case we manage arm, right?

[JostMigenda]

I'll accept the merge and we can pause till I provide the build folders. A question, we would need an intel mac and an arm mac prebuild folder, in case we manage arm, right?

Not necessarily. In principle, Qt versions that support ARM Macs also support cross builds or universal binaries; but how well that works in practice remains to be seen after we’ve upgraded Qt to a more recent version.