3 to 4 #2
Open
3 to 4 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to try-with-resources TemplateFile.java: In retrieveFirstAndLastNames(), fixed a bug.
Reformat sdk toolkit descriptor Move some descriptor informations in the toolkit pom.xml
Remove maven version from the sdk toolkit extract folder.
The copyright maven was broken with files which were not commited. This is a regression introduced by 84e18a7.
The invalidCredRecentCount counter was maintained but not used anywhere since commit 6e1f91e.
* Move copyright-maven-plugin executions to the repositority parent pom to allow copyright checks fail fast. * Remove duplicated reporting section in opendj-sdk-parent/pom.xml file
* Creates a parameter for the Git branch which is used against HEAD in the diff command. And change its default value from master to origin/master (Thanks to JNR for the tip). * Also fix little bug (duplicate file name in the incorrect file list)
Other code cleanups. Reset the clirr api changes against 3.0.0-SNAPSHOT (waiting for 3.0.0)
* Update THIRDPARTYREADME file according to the BOM 4.1.1 * Update copyright year when it was needed
Copyright plugin now supports .properties files. Thanks to JNR for the RFE.
Removes useless code in copyright maven plugin.
SSLContextBuilder.java: Added constant PROTOCOL_TLS1_2 (RFC 5246: TLS version 1.2) Code cleanup
Ensure default attribute types are created with the provided syntax AttributeType.java: These changes allow the server to create custom AttributeTypes with a non strict schema. Schema.java: Consequence of the changes to AttributeType. Added getAttributeType(String name, Syntax).
Moves the excluded files list to the repository top pom (sdk-bom) since the copyright maven plugin execution has been moved. This will enable the exclude file list which was unexpectedly ignored since c9b49f7.
Creates a property name to allow user to set the reference git branch to use in the diff command. Also log a quick message to explain how to use the property. Extracs some constants to mutualize the code.
… launching perf test For all *rate tools, abort the run if the tool cannot connect to the server (wrong bind options, server unreachable, etc.) PerformanceRunner.java: Added validateCanConnectToServer()
Reduced vertical spacing for the whole file and grouped linked fields together.
Added AttributeDescription.getNameOrOID() + create() methods to return the user supplied attribute name
…luedAttributes() has the expected effect This commit fixes the usage of 'useReplaceMaxValues' to match its description and amends the unit test for testDiffEntriesReplaceSingleValue
Also add a unit test to cover this
It had been temporarily added to ease migration to AttributeType
* delegate construction of enumeration syntax and matching rule to Syntax.Builder#addToSchema(boolean) and route all construction paths through this method in order to have consistent behavior * add user friendly name for enumeration matching rules and ensure that removal uses the OID rather than the name * fix unit tests which were dependent on previous broken behavior.
…ons without a SUP or SYNTAX * added SchemaOptions#ALLOW_ATTRIBUTE_TYPES_WITH_NO_SUP_OR_SYNTAX * updated SchemaBuilder/AttributeType to use the new option * updated unit tests to deal with change in behavior.
@OverRide public <VOUT, EOUT extends Exception> Promise<VOUT, EOUT> thenAsync(AsyncFunction<? super R, VOUT, EOUT> onResult, AsyncFunction<? super LdapException, VOUT, EOUT> onException, AsyncFunction<? super RuntimeException, VOUT, EOUT> onRuntimeException) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.