Restructure and update Jakarta authorization code #30293

jhanders34 · 2024-11-25T23:39:52Z

Update to have interfaces in EJB and Web bundles so that can reference actual classes instead of using Object
Move JaccService function to the corresponding EJB and Web projects to keep the methods with their appropriate container function
Update to add PrincipalMapper to PolicyContextHandlerImpl in preparation of adding PrincipalMapper implementation
Update to use instance methods instead of static methods in PolicyConfigurationManager
Inline most of the Validator and Propagator function into the EJB and Web classes except for EJB propagator which is used by both EJB function and base Jacc function
I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

jhanders34 · 2024-11-25T23:57:24Z

!build
spawn.fullfat.buckets=com.ibm.ws.ejbcontainer.security.jacc_fat,com.ibm.ws.ejbcontainer.security.jacc_fat.2,com.ibm.ws.ejbcontainer.security.jacc_fat.2.1,com.ibm.ws.webcontainer.security.jacc.1.5_fat,com.ibm.ws.security.jaspic_fat

LibbyBot · 2024-11-25T23:57:33Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3fa5602b-7025-4fa2-9cfd-32a79f1cdca6

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-25T23:57:34Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=525a905a-882a-484f-a861-27d8b73e532f

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T04:47:26Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

40 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 infrastructure code files were changed.

LibbyBot · 2024-11-26T17:28:15Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=525a905a-882a-484f-a861-27d8b73e532f has errors/failures.

LibbyBot · 2024-11-26T17:28:19Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3fa5602b-7025-4fa2-9cfd-32a79f1cdca6 has errors/failures.

jhanders34 · 2024-11-26T18:26:28Z

!build spawn.fullfat.buckets=com.ibm.ws.ejbcontainer.security.jacc_fat,com.ibm.ws.ejbcontainer.security.jacc_fat.2,com.ibm.ws.ejbcontainer.security.jacc_fat.2.1,com.ibm.ws.webcontainer.security.jacc.1.5_fat,com.ibm.ws.security.jaspic_fat

LibbyBot · 2024-11-26T18:26:47Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=bc6dbca4-a0f0-4cbf-b3a6-f40cc49c29c2

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T18:26:48Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d0a0c5a9-5a09-4c73-b66b-374a077a8285

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T18:34:07Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-26T18:40:55Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

jhanders34 · 2024-11-26T18:59:12Z

!build spawn.fullfat.buckets=com.ibm.ws.ejbcontainer.security.jacc_fat,com.ibm.ws.ejbcontainer.security.jacc_fat.2,com.ibm.ws.ejbcontainer.security.jacc_fat.2.1,com.ibm.ws.webcontainer.security.jacc.1.5_fat,com.ibm.ws.security.jaspic_fat

LibbyBot · 2024-11-26T18:59:31Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=cff28fa3-a0ae-48dc-9c67-35e2638a1ee7

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T18:59:32Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=82b17b9b-b517-4b8a-9a5a-fbd9473c67da

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T19:06:51Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-26T19:07:14Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

jhanders34 · 2024-11-26T23:17:13Z

!build spawn.fullfat.buckets=com.ibm.ws.ejbcontainer.security.jacc_fat,com.ibm.ws.ejbcontainer.security.jacc_fat.2,com.ibm.ws.ejbcontainer.security.jacc_fat.2.1,com.ibm.ws.webcontainer.security.jacc.1.5_fat,com.ibm.ws.security.jaspic_fat

LibbyBot · 2024-11-26T23:17:23Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0596815a-bbc0-4504-880d-eca277eca3e0

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T23:17:24Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d5949def-2f8d-4b92-a8d2-2ba0065eff31

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-26T23:28:35Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
41 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-26T23:29:46Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
41 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-27T04:33:07Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=bc6dbca4-a0f0-4cbf-b3a6-f40cc49c29c2 has errors/failures.

LibbyBot · 2024-11-27T06:34:07Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=82b17b9b-b517-4b8a-9a5a-fbd9473c67da has errors/failures.

LibbyBot · 2024-11-27T07:48:12Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d5949def-2f8d-4b92-a8d2-2ba0065eff31 has errors/failures.

LibbyBot · 2024-11-27T16:23:12Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=cff28fa3-a0ae-48dc-9c67-35e2638a1ee7 has errors/failures.

jhanders34 · 2024-11-27T18:07:54Z

!build spawn.fullfat.buckets=com.ibm.ws.ejbcontainer.security.jacc_fat,com.ibm.ws.ejbcontainer.security.jacc_fat.2,com.ibm.ws.ejbcontainer.security.jacc_fat.2.1,com.ibm.ws.webcontainer.security.jacc.1.5_fat,com.ibm.ws.security.jaspic_fat

LibbyBot · 2024-11-27T18:08:03Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=f81a7533-062d-4d22-93a9-8632ec7d5c3a

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-27T18:08:06Z

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3f6f3a1f-2eda-4f38-b516-0b5e231ac928

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-11-27T18:15:16Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
41 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-27T18:15:59Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
41 product code files were changed.
Please describe in a separate comment how you tested your changes.

LibbyBot · 2024-11-27T19:03:12Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d0a0c5a9-5a09-4c73-b66b-374a077a8285 has errors/failures.

LibbyBot · 2024-11-28T02:58:28Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3f6f3a1f-2eda-4f38-b516-0b5e231ac928 has errors/failures.

LibbyBot · 2024-11-28T05:28:12Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0596815a-bbc0-4504-880d-eca277eca3e0 has errors/failures.

LibbyBot · 2024-11-28T14:38:12Z

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=f81a7533-062d-4d22-93a9-8632ec7d5c3a - Open Liberty Personal Build RTC completed with errors/failures.

wraschke · 2024-12-02T00:57:20Z

!libby@dev (view Open Liberty Delivery Requirements Verification - ❌ completed with errors/failures.)

LibbyBot · 2024-12-02T01:04:02Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
41 product code files were changed.
Please describe in a separate comment how you tested your changes.

wraschke · 2024-12-02T14:26:37Z

@jhanders34 please bear with me while I run test pipelines to fix the bug we've been discussing in the past few weeks.

wraschke · 2024-12-02T17:37:38Z

Please ignore! !libby (view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)

LibbyBot · 2024-12-02T18:11:32Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 infrastructure code files were changed.
41 product code files were changed.
Please describe in a separate comment how you tested your changes.

- Update to have interfaces in EJB and Web bundles so that can reference actual classes instead of using Object - Move JaccService function to the corresponding EJB and Web projects to keep the methods with their appropriate container function - Update to add PrincipalMapper to PolicyContextHandlerImpl in preparation of adding PrincipalMapper implementation - Update to use instance methods instead of static methods in PolicyConfigurationManager - Inline most of the Validator and Propagator function into the EJB and Web classes except for EJB propagator which is used by both EJB function and base Jacc function

jhanders34 · 2024-12-18T21:53:09Z

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-18T22:00:12Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

24 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 infrastructure code files were changed.
6 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

wraschke · 2024-12-19T20:15:07Z

Sorry, Jared, please ignore any resulting pipelines. This is for testing bug we discussed.
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)

!libby@dev

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-19T20:23:01Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

24 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 infrastructure code files were changed.
6 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

jhanders34 · 2024-12-20T16:23:47Z

!build
(view Open Liberty Personal Build - ❌ completed with errors/failures.)
fat.buckets.to.run=all

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-20T16:31:08Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

24 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 infrastructure code files were changed.
6 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
40 product code files were changed.
Please describe in a separate comment how you tested your changes.

jhanders34 self-assigned this Nov 25, 2024

jhanders34 force-pushed the branch3 branch from 4404630 to 98e7de4 Compare November 25, 2024 23:59

LibbyBot added the CLA Signed label Nov 26, 2024

jhanders34 force-pushed the branch3 branch from 98e7de4 to 9852f5e Compare November 26, 2024 16:33

jhanders34 added this to the [Iteration 24.24] Nov 25 - Dec 6 milestone Nov 26, 2024

jhanders34 requested review from arkarkala and ayoho November 26, 2024 18:27

jhanders34 force-pushed the branch3 branch from 9852f5e to 27611eb Compare November 26, 2024 18:58

jhanders34 force-pushed the branch3 branch from 27611eb to 593b617 Compare November 26, 2024 23:11

jhanders34 force-pushed the branch3 branch from 593b617 to e93defc Compare December 4, 2024 16:18

jhanders34 force-pushed the branch3 branch from e93defc to d023041 Compare December 18, 2024 21:44

Add tests to validate PolicyContextHandlers are set correctly.

13b26a8

jhanders34 force-pushed the branch3 branch from d023041 to 13b26a8 Compare December 20, 2024 00:10

Restructure and update Jakarta authorization code #30293

Are you sure you want to change the base?

Restructure and update Jakarta authorization code #30293

Conversation

jhanders34 commented Nov 25, 2024 • edited Loading

jhanders34 commented Nov 25, 2024

LibbyBot commented Nov 25, 2024

LibbyBot commented Nov 25, 2024

LibbyBot commented Nov 26, 2024

Code analysis and actions

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

jhanders34 commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

Code analysis and actions

LibbyBot commented Nov 26, 2024

Code analysis and actions

jhanders34 commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

Code analysis and actions

LibbyBot commented Nov 26, 2024

Code analysis and actions

jhanders34 commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

LibbyBot commented Nov 26, 2024

Code analysis and actions

LibbyBot commented Nov 26, 2024

Code analysis and actions

LibbyBot commented Nov 27, 2024

LibbyBot commented Nov 27, 2024

LibbyBot commented Nov 27, 2024

LibbyBot commented Nov 27, 2024

jhanders34 commented Nov 27, 2024

LibbyBot commented Nov 27, 2024

LibbyBot commented Nov 27, 2024

LibbyBot commented Nov 27, 2024

Code analysis and actions

LibbyBot commented Nov 27, 2024

Code analysis and actions

LibbyBot commented Nov 27, 2024

LibbyBot commented Nov 28, 2024

LibbyBot commented Nov 28, 2024

LibbyBot commented Nov 28, 2024

wraschke commented Dec 2, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 2, 2024

Code analysis and actions

wraschke commented Dec 2, 2024

wraschke commented Dec 2, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 2, 2024

Code analysis and actions

jhanders34 commented Dec 18, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 18, 2024

Code analysis and actions

wraschke commented Dec 19, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 19, 2024

Code analysis and actions

jhanders34 commented Dec 20, 2024 • edited by LibbyBot Loading

LibbyBot commented Dec 20, 2024

Code analysis and actions

jhanders34 commented Nov 25, 2024 •

edited

Loading

wraschke commented Dec 2, 2024 •

edited by LibbyBot

Loading

wraschke commented Dec 2, 2024 •

edited by LibbyBot

Loading

jhanders34 commented Dec 18, 2024 •

edited by LibbyBot

Loading

wraschke commented Dec 19, 2024 •

edited by LibbyBot

Loading

jhanders34 commented Dec 20, 2024 •

edited by LibbyBot

Loading