Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding retry port TCP option to Servlet 4.0 Fat_2 #30348

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Adding retry port TCP option to Servlet 4.0 Fat_2 #30348

merged 1 commit into from
Dec 6, 2024

Conversation

mrsaldana
Copy link
Member

@mrsaldana mrsaldana commented Dec 5, 2024 •
edited
Loading

Fixes #30349

@mrsaldana mrsaldana requested a review from pnicolucci December 5, 2024 14:53
@mrsaldana mrsaldana self-assigned this Dec 5, 2024
@mrsaldana
Copy link
Member Author

mrsaldana commented Dec 5, 2024 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@mrsaldana mrsaldana requested a review from isaacrivriv December 5, 2024 15:22
isaacrivriv
isaacrivriv approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@isaacrivriv isaacrivriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks for working on this!

@LibbyBot
Copy link

LibbyBot commented Dec 6, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • Please describe in a separate comment how you tested your changes.

  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

LibbyBot commented Dec 6, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Qd4WcLNkEe-Q24Sd2QdBoQ

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@mrsaldana mrsaldana merged commit 930fc41 into OpenLiberty:integration Dec 6, 2024
4 checks passed
@mrsaldana mrsaldana mentioned this pull request Dec 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolucci pnicolucci pnicolucci left review comments

@isaacrivriv isaacrivriv isaacrivriv approved these changes

Assignees

@mrsaldana mrsaldana

Labels
CLA Signed noproductcode team:Sirius
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry Option for Port Binding in Servlet 4.0 fat_2
4 participants
@mrsaldana @LibbyBot @pnicolucci @isaacrivriv