Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Flops tabular aero so that it correctly supports passing the lift independent and dependent polars. #604

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for Flops tabular aero so that it correctly supports passing the lift independent and dependent polars. #604

wants to merge 3 commits into from

Conversation

Kenneth-T-Moore
Copy link
Member

Summary

  1. Fixed bug where the FLOPS-based tabular aero was not promoting its training inputs from the metamodels, and was not adding them to the phase parameters.
  2. Added Aircraft.Design.LIFT_INDEPENDENT_DRAG_POLAR and Aircraft.Design.LIFT_DEPENDENT_DRAG_POLAR to the variable hierarchy.
  3. Fixed the tabular data test so that it will actually fail if the feature doesn't work.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@jkirk5 jkirk5 self-requested a review November 13, 2024 21:33
@jkirk5 jkirk5 enabled auto-merge December 5, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkirk5 jkirk5 jkirk5 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FLops tabular aero is not working with training data.
2 participants
@Kenneth-T-Moore @jkirk5