-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbosity cleanup and reduced warnings/printouts #636
Open
jkirk5
wants to merge
25
commits into
OpenMDAO:main
Choose a base branch
from
jkirk5:cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,583
−1,227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed input_filename argument to input_data
more verbosity updates for preprocessor stack
verbosity updates
jkirk5
commented
Dec 26, 2024
jkirk5
changed the title
Verbosity cleanup round
Verbosity cleanup and reduced warnings/printouts
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made a variety of updates related to Aviary's printouts and giving users more control over them, as well as some related housekeeping items while I was looking at that part of the code.
Printouts
DEBUG
.NUM_ENGINES
but notNUM_WING_ENGINES
(not comprehensive).Verbosity
.csv
orAviaryValues
object when using the Python interface (L1 or L2) as well as from the CLIrun_aviary()
now has a verbosity argument which overrides whatever is in the aircraft data. Can be passed via CLI.method_for_level2.py
have optional verbosity arguments which override any other verbosity sources for that method call only. In case you want to run a specific step with higher/lower verbosity when using L2.QUIET
verbosity, including all benchmark tests.AviaryProblem
is nowIPOPT
instead ofSNOPT
.Bugfixes
AviaryProblems
now uses openmdao default problem name when given an AviaryValues, instead of trying to name it off of the filenamePath().stem
.All of
methods_for_level2.py
got the autoformat treatment since I touched a bunch of pieces of it - makes for a messy diff, but this file was very inconsistently styled, IMO it needed to be done.Related Issues
Backwards incompatibilities
API changes - Level 2
run_aviary()
: renamedaircraft_filename
argument toaircraft_data
to reflect capability to provide anAviaryValues
object instead of a filepath.New Dependencies
None