PPC970: drop -mcpu=970 which seems to produce faulty code #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4376
For a reason yet unknown, using
-mcpu=[may] produce a broken library on macOS PowerPC when building for G5 cpu (PPC970 kernel).Drop the flag for now, also for PPCG4 for the sake of consistency and safety.
P. S. Testing on *BSD and Linux is encouraged, but I have no set-up for that. If someone does it later on, please make sure not to use
-mcpufor macOS case, unless it is well-tested.@martin-frbg Hopefully this is the final fix for this issue :)
I have verified that both cases which failed before now work (
R-floatlaunches without a failure andflexiblasfinds OpenBLAS).UPD. By Iain’s (he is from GCC upstream) response in the issue, looks like dropping
-mcpuis the right thing.