Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use torch.amax in ReduceMax forward to support multiplie dim #571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ice-tong
Copy link
Contributor

@ice-tong ice-tong commented Aug 22, 2024

Motivation

The difference between max/min and amax/amin is:

  • amax/amin supports reducing on multiple dimensions,
  • amax/amin does not return indices,
  • amax/amin evenly distributes gradient between equal values, while max(dim)/min(dim) propagates gradient only to a single index in the source tensor.

Modification

  • ppq/executor/op/torch/default.py
    • Use torch.amax in ReduceMax forward to support multiplie dim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant