Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

479 WIP - refactor net 8.0 #489

Draft
wants to merge 5 commits into
base: Development
Choose a base branch
from

Conversation

clouths
Copy link

@clouths clouths commented Mar 23, 2024

This PR contain a refactor of the way you setup the project using docker compose.
There is a container for the asset which is a submodule of OPResource.
There is a container for the db which is a submodule of OPDB.
There is a container for the server using the files from this repository.

Changes:

  • Add submodules for the asset and the db
  • Add basic docker compose setup
  • Add Makefile to help start/stop/restart/log containers
  • convert the project to net 8.0 (thanks Fratakal)
  • replace System.Drawing with SkiaSharp for linux support
  • refactor database access for linux support

Fratakal and others added 3 commits March 21, 2024 20:18
- Add basic docker compose setup
- WIP convert the project to net 8.0
@clouths clouths added WIP Work-in-progress; advice and reviews welcome but work is not finalized Refactor Code maintainability, style, or other non-functional changes labels Mar 23, 2024
@Fratakal
Copy link

Fratakal commented Mar 24, 2024

Hey!
You can check my fork. It is already migrated to Net8 and does work fine so far.
Release build is running localy without issues since 4 days or so.

What was done :

  • Basically it update all the csproj (correct the Perpetuum.server, that was a bit broken if I remeber correctly)
  • Update all dependency add some (For console command arg that microsoft stoped supporting, I was not willing to change too much code)
  • Change the memorystream binary parsing that was considered unsafe therefore generated an error => changed for a simpler newtonsoft parsing.

You can use it.
or I can start a PR.

@Fratakal
Copy link

BTW
I'm too lazy *look shiny code there !* to copy/paste file correctly into the server folder publish Admintool & Server work like a charm

@aqpanaciy
Copy link

Hey! You can check my fork. It is already migrated to Net8 and does work fine so far. Release build is running localy without issues since 4 days or so...

The purpose of moving the code to .NET is, in the future, to move to the Linux platform. Thanks for the message, I looked into your fork. For launching on Windows OS, your changes are quite suitable, but for migration to Linux additional changes are needed. They are mainly related to the work of database access and the lack of support for System.Drawing on Linux. Anyway, thanks.

clouths added 2 commits May 6, 2024 20:30
…er is compiling correctly, wip migration to linux support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Code maintainability, style, or other non-functional changes WIP Work-in-progress; advice and reviews welcome but work is not finalized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants