Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scenario and object override strings #2956

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

AaronVanGeffen
Copy link
Member

@AaronVanGeffen AaronVanGeffen commented Oct 30, 2024

Ties in with OpenRCT2/OpenRCT2#23070. These overrides have been replaced with objects. (cf. OpenRCT2/objects#350).

This comment was marked as outdated.

This comment was marked as outdated.

@Gymnasiast
Copy link
Member

As it turns out, the object overrides have been non-functional since the summer of 2023. Could you remove these as well? In a separate commit, so that we can easily find them back.

@AaronVanGeffen AaronVanGeffen force-pushed the remove-scenario-overrides branch from 081e896 to 46eb044 Compare October 30, 2024 21:07
@AaronVanGeffen AaronVanGeffen changed the title Remove scenario override strings Remove scenario and object override strings Oct 30, 2024
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 669 (+489) 1 (-1) 1765 (-139)
ca-ES 536 (+489) 0 (-1) 84 (-39)
cs-CZ 673 (+174) 0 140 (-108)
da-DK 578 (+489) 0 239 (-325)
de-DE 489 (+489) 0 (-1) 142 (-220)
en-US 3890 (+429) 0 1 (-391)
eo-ZZ 489 (+489) 0 (-1) 65 (-29)
es-ES 524 (+489) 0 (-1) 160 (-148)
fi-FI 489 (+489) 0 (-1) 97 (-25)
fr-FR 538 (+489) 0 (-1) 135 (-33)
hu-HU 489 (+489) 0 87 (-39)
it-IT 526 (+486) 0 (-1) 131 (-217)
ja-JP 489 (+429) 0 (-1) 122 (-214)
ko-KR 489 (+489) 0 (-1) 89 (-110)
nb-NO 578 (+489) 0 164 (-319)
nl-NL 489 (+489) 0 (-13) 175 (-309)
pl-PL 689 (+432) 0 (-1) 131 (-277)
pt-BR 489 (+489) 0 (-1) 133 (-21)
ru-RU 1592 (+171) 0 65 (-46)
sv-SE 543 (+432) 0 (-1) 151 (-205)
tr-TR 907 (+429) 0 (-1) 98 (-284)
uk-UA 573 (+474) 33 (-1) 726 (-411)
vi-VN 769 (+432) 2 (-1) 2788 (-431)
zh-CN 553 (+489) 0 (-1) 30 (-5)
zh-TW 664 (+432) 0 105 (-228)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

fr-CA 4046 0 0

@Gymnasiast Gymnasiast merged commit af95145 into master Oct 30, 2024
1 check passed
@Gymnasiast Gymnasiast deleted the remove-scenario-overrides branch October 30, 2024 22:13
@tupaschoal
Copy link
Member

https://github.com/OpenRCT2/Localisation/blob/master/.github/workflows/translation_check.py can now be simplified

@Gymnasiast
Copy link
Member

@tupaschoal #2958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants