-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update object string dumps #2957
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I want to be able to see if this doesn’t accidentally overwrite any existing translations. I want to do that as follows:
|
I can easily do that ( |
Yes, please. |
d60de15
to
89bee6f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
89bee6f
to
698960a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Could you re-dump to account for the changed IDs? I already merged the "sort" commit. |
698960a
to
4e35f0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4e35f0c
to
1eb2105
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1eb2105
to
70813a4
Compare
Check resultsFor details go to
Other translations
|
Updated the dumps using the branch for OpenRCT2/objects#353, i.e. taking the new Polish translations from #2964 into account. NB: not #2966, so please merge this first. |
Apologies, I already merged #2966 before I saw your request. |
Thankfully, there doesn't seem to be a conflict. Phew! I'm just glad I don't have to do it over again 😄 |
Check resultsFor details go to
Other translations
|
Check resultsFor details go to
Other translations
|
With the scenario text PR in, this PR updates the object string dumps for all languages, sorted by object id.
This PR as a whole has a pretty terrible diff, as the previous dump was apparently not ordered by id. The first commit orders the files in-tree by object identifier key, while the second commit brings the dumps up-to-date.