fix wrong order in heightmap smoothing window

[arekdurlik]

The input window for heightmap smooth strength has strings in the wrong order. 1-20 is the range that the buttons to change the value allow, so I guess that's correct.

Before:

After:

[github-actions]

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

	Missing The translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)	Not needed The translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)	Same The translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ca-ES	2	0	86
da-DK	2	0	245
de-DE	4	0	141
eo-ZZ	2	0	65
fi-FI	4	0	96
gl-ES	4	2	97
hu-HU	4	0	86
it-IT	2	0	133
ja-JP	4	0	121
ko-KR	2	0	89
nl-NL	2	0	175
pl-PL	2	0	96
pt-BR	2	0	133

Other translations

	Missing The translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)	Not needed The translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)	Same The translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG	184	1	1765
cs-CZ	188	0	140
en-US	3405	0	1
es-ES	37	0	159
fr-CA	3561	0	0
fr-FR	53	0	134
nb-NO	93	0	163
ru-RU	1107	0	65
sv-SE	58	0	150
tr-TR	422	0	98
uk-UA	88	33	725
vi-VN	284	2	2788
zh-CN	68	0	30
zh-TW	179	0	105

[AaronVanGeffen]

Rather than swapping the strings in the language packs (which should happen in the Localisation repository), I suggest we instead swap the numbers in UiStringIds.h:

        STR_ENTER_SMOOTH_STRENGTH = 6708,
// ...
        STR_SMOOTH_STRENGTH = 6709,

[arekdurlik]

That's a much nicer way of fixing it. Should I close this and open a PR there? I haven't been able to build the game myself though, and won't be able to test it, so maybe an issue would be better? 😅

[AaronVanGeffen]

No worries. I've filed OpenRCT2/OpenRCT2#23334 to replace this PR.