Skip to content

Commit

Permalink
chore: fix some typos in comments (#1010)
Browse files Browse the repository at this point in the history
Signed-off-by: fanqiaojun <[email protected]>
Co-authored-by: Eric Lau <[email protected]>
  • Loading branch information
fanqiaojun and ericglau authored Apr 15, 2024
1 parent 7a77f68 commit 9932c6a
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/core/src/cli/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ test('validate - reference without contract option', async t => {
);
});

test('validate - emtpy contract string', async t => {
test('validate - empty contract string', async t => {
const temp = await getTempDir(t);
const buildInfo = await artifacts.getBuildInfo(`contracts/test/cli/Validate.sol:StorageV1`);
await fs.writeFile(path.join(temp, 'validate.json'), JSON.stringify(buildInfo));
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/storage/report-rename-retype.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,15 @@ function getReport(original: StorageLayout, updated: StorageLayout) {
return comparator.compareLayouts(originalDetailed, updatedDetailed);
}

test('succesful rename', t => {
test('successful rename', t => {
const v1 = t.context.extractStorageLayout('RenameV1');
const v2 = t.context.extractStorageLayout('RenameV2');
const report = getReport(v1, v2);
t.true(report.ok);
t.snapshot(report.explain());
});

test('succesful retype', t => {
test('successful retype', t => {
const v1 = t.context.extractStorageLayout('RetypeV1');
const v2 = t.context.extractStorageLayout('RetypeV2');
const report = getReport(v1, v2);
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/storage/report-rename-retype.test.ts.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ The actual snapshot is saved in `report-rename-retype.test.ts.snap`.

Generated by [AVA](https://avajs.dev).

## succesful rename
## successful rename

> Snapshot 1
''

## succesful retype
## successful retype

> Snapshot 1
Expand Down
Binary file modified packages/core/src/storage/report-rename-retype.test.ts.snap
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/core/src/validate/overrides.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export interface StandaloneValidationOptions extends ProxyKindOption {
}

/**
* Validation options in the context of an upgrade (with storage layout comparisions with a previous implementation).
* Validation options in the context of an upgrade (with storage layout comparisons with a previous implementation).
*/
export interface ValidationOptions extends StandaloneValidationOptions {
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-hardhat/src/utils/contract-instance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { attach } from './ethers';

/**
* Gets a contract instance from a deployment, where the deployment may be remote.
* If the deployment is remote, the instance has an overriden `waitForDeployment` method to wait for the remote deployment
* If the deployment is remote, the instance has an overridden `waitForDeployment` method to wait for the remote deployment
* and update its `deploymentTransaction` with the new transaction hash if it was detected to have changed.
*
* @param hre The Hardhat Runtime Environment
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-hardhat/test/import-v4.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ test('wrong kind', async t => {
await proxy.waitForDeployment();

// specify wrong kind.
// an error is expected since the admin adress is zero
// an error is expected since the admin address is zero
const e = await t.throwsAsync(async () =>
upgrades.forceImport(await proxy.getAddress(), GreeterProxiable, { kind: 'transparent' }),
);
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-hardhat/test/import-v5.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ test('wrong kind', async t => {
await proxy.waitForDeployment();

// specify wrong kind.
// an error is expected since the admin adress is zero
// an error is expected since the admin address is zero
const e = await t.throwsAsync(async () =>
upgrades.forceImport(await proxy.getAddress(), GreeterProxiable, { kind: 'transparent' }),
);
Expand Down

0 comments on commit 9932c6a

Please sign in to comment.