Defender: Improve license type handling #1013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Hardhat, fixes the same issue identified in OpenZeppelin/defender-deploy-client-cli#8
Equivalent to OpenZeppelin/openzeppelin-foundry-upgrades#43
Updates submodule for latest docs from OpenZeppelin/openzeppelin-foundry-upgrades#43
Contracts have SPDX license identifiers, while block explorer verification (e.g. Etherscan source code verification) through Defender SDK requires a format that matches with https://etherscan.io/contract-license-types.
This PR does the following:
licenseType
based on SPDX license identifier, instead of using the SPDX license identifier directly.licenseType
option which can override the SPDX license identifier.skipLicenseType
option which can skip setting a license type.Breaking change:
// SPDX-License-Identifier: UNLICENSED
according to Solidity docs, or set thelicenseType
option to"None"
.