Include return param names in modified namespaced compilation #1050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a modified copy of solc input to extract namespaced storage layout, we converted function return variables to unnamed
bool
s e.g.return (bool)
. This allowed compilation to pass even if the NatSpec was documented with the return variable name as@return x
However, if the NatSpec of the return variable was documented by the user as in the below example using
@param x
instead of@return x
, this fails the modified compilation even though the original format was allowed by Solidity:We should keep the return param name in the return parameters to avoid this issue.
Fixes #1049