Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: Get rid of sol_interface! macro #425

Open
1 task done
bidzyyys opened this issue Nov 28, 2024 · 0 comments
Open
1 task done

[Refactor]: Get rid of sol_interface! macro #425

bidzyyys opened this issue Nov 28, 2024 · 0 comments
Labels
effort: medium Default level of effort. needs triage Needs to be assigned the appropriate labels priority: 1 We will do our best to deal with this. type: ref A code update that doesn't meaningfully change functionality.

Comments

@bidzyyys
Copy link
Collaborator

bidzyyys commented Nov 28, 2024 •
edited
Loading

What is the feature you would like to see?

Investigate if there is a possibility to remove all occurrences of sol_interface and use our Rust traits.
E.g. VestingWallet contract needs this refactor (for calling Erc20::balanceOf).

    stylus_sdk::stylus_proc::sol_interface! {
        /// Interface of the ERC-20 token.
        interface IErc20 {
            function balanceOf(address account) external view returns (uint256);
        }
    }

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@bidzyyys bidzyyys added priority: 1 We will do our best to deal with this. effort: medium Default level of effort. needs triage Needs to be assigned the appropriate labels type: ref A code update that doesn't meaningfully change functionality. labels Nov 28, 2024
@bidzyyys bidzyyys mentioned this issue Nov 28, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. needs triage Needs to be assigned the appropriate labels priority: 1 We will do our best to deal with this. type: ref A code update that doesn't meaningfully change functionality.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bidzyyys