Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VestingWallet #402

Merged
merged 147 commits into from
Nov 28, 2024
Merged

feat: Add VestingWallet #402

merged 147 commits into from
Nov 28, 2024

Conversation

0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Nov 11, 2024

Resolves #348

PR Checklist

  • Unit Tests
  • E2E Tests
  • Documentation

@0xNeshi
Copy link
Collaborator Author

0xNeshi commented Nov 20, 2024

@ggonzalez94 @bidzyyys @qalisander would appreciate your help to understand why gas-bench workflow fails when vesting-wallet benches are added to benches/src/main.rs 🙏
See example https://github.com/OpenZeppelin/rust-contracts-stylus/actions/runs/11930050607/job/33250077909

I removed it until I figure this out.

Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge!

contracts/src/finance/vesting_wallet.rs Outdated Show resolved Hide resolved
contracts/src/finance/vesting_wallet.rs Show resolved Hide resolved
contracts/src/finance/vesting_wallet.rs Outdated Show resolved Hide resolved
contracts/src/finance/vesting_wallet.rs Outdated Show resolved Hide resolved
contracts/src/finance/vesting_wallet.rs Outdated Show resolved Hide resolved
contracts/src/finance/vesting_wallet.rs Outdated Show resolved Hide resolved
examples/vesting-wallet/tests/vesting-wallet.rs Outdated Show resolved Hide resolved
examples/vesting-wallet/tests/vesting-wallet.rs Outdated Show resolved Hide resolved
Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Awesome job @0xNeshi
I think we're ready to ship, may be some very minor things left..

@0xNeshi 0xNeshi requested a review from bidzyyys November 26, 2024 12:10
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready to merge 🚀

contracts/src/finance/vesting_wallet.rs Outdated Show resolved Hide resolved
@0xNeshi 0xNeshi requested a review from bidzyyys November 27, 2024 07:19
CHANGELOG.md Outdated Show resolved Hide resolved
GUIDELINES.md Outdated Show resolved Hide resolved
mod token {
stylus_sdk::stylus_proc::sol_interface! {
/// Interface of the ERC-20 token.
interface IErc20 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bidzyyys bidzyyys merged commit 1244d38 into main Nov 28, 2024
25 checks passed
@bidzyyys bidzyyys deleted the vesting-wallet branch November 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add VestingWallet
3 participants