feat: add ERC1155 Pausable Extension #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
✅ Deploy Preview for contracts-stylus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bidzyyys
changed the title
0xNeshi
reviewed
Dec 4, 2024
Co-authored-by: Nenad <[email protected]>
Co-authored-by: Nenad <[email protected]>
Co-authored-by: Nenad <[email protected]>
qalisander
approved these changes
Dec 6, 2024
| @@ -1392,6 +1408,24 @@ async fn unpauses(alice: Account) -> eyre::Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[e2e::test] | |||
| async fn unpause_reverts_in_unpaused_state(alice: Account) -> eyre::Result<()> { | |||
There was a problem hiding this comment.
Are we switching to <func_name>_reverts_<description> convention already?
There was a problem hiding this comment.
Make sense to change it everywhere
There was a problem hiding this comment.
Yes, let's start adding tests that follow this naming convention. We may rename the rest in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #349
PR Checklist