Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: drop math for storage guard #446

Merged
merged 4 commits into from
Dec 10, 2024
Merged

ref: drop math for storage guard #446

merged 4 commits into from
Dec 10, 2024

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Dec 10, 2024 •
edited
Loading

Drop add_assign_unchecked and sub_assign_unchecked functions for StorageGuardMut, since guard already implements Deref and DerefMut to wrapped types.

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 990c40b
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/67586cfb26c17000080f01f1

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.1%. Comparing base (091d06d) to head (990c40b).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/utils/math/storage.rs 100.0% <ø> (+25.0%) ⬆️

@qalisander qalisander marked this pull request as ready for review December 10, 2024 12:51
0xNeshi
0xNeshi approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

bidzyyys
bidzyyys approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @qalisander but CHANGELOG first 🔔

@qalisander
Copy link
Member Author

qalisander commented Dec 10, 2024 •
edited
Loading

That is internal refactoring. No change log update required

@qalisander qalisander merged commit 49ff333 into main Dec 10, 2024
24 checks passed
@0xNeshi 0xNeshi deleted the drop-math-for-storage-guard branch December 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys bidzyyys approved these changes

@0xNeshi 0xNeshi 0xNeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qalisander @0xNeshi @bidzyyys