Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy) (#440)" #464

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Dec 18, 2024

Towards #355

Reentrancy is necessary for Erc20FlashMint.

refs: da0249b

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit e725109
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/6762d6c85769d600086ca2d5

@qalisander qalisander force-pushed the feat/enable-reetrancy branch from 3b00107 to 8791694 Compare December 18, 2024 14:05
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (5fce6db) to head (e725109).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/utils/cryptography/ecdsa.rs 0.0% 18 Missing ⚠️
contracts/src/finance/vesting_wallet.rs 0.0% 1 Missing ⚠️
contracts/src/token/erc1155/mod.rs 66.6% 1 Missing ⚠️
contracts/src/token/erc20/extensions/permit.rs 0.0% 1 Missing ⚠️
contracts/src/token/erc721/mod.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc1155/extensions/supply.rs 81.1% <100.0%> (ø)
...tracts/src/token/erc1155/extensions/uri_storage.rs 98.2% <ø> (ø)
contracts/src/token/erc20/utils/safe_erc20.rs 17.0% <ø> (ø)
...ntracts/src/token/erc721/extensions/consecutive.rs 98.1% <ø> (ø)
contracts/src/finance/vesting_wallet.rs 55.6% <0.0%> (ø)
contracts/src/token/erc1155/mod.rs 96.9% <66.6%> (+<0.1%) ⬆️
contracts/src/token/erc20/extensions/permit.rs 0.0% <0.0%> (ø)
contracts/src/token/erc721/mod.rs 97.2% <50.0%> (ø)
contracts/src/utils/cryptography/ecdsa.rs 47.1% <0.0%> (-10.8%) ⬇️

@0xNeshi 0xNeshi merged commit 4de08e5 into main Dec 18, 2024
24 checks passed
@0xNeshi 0xNeshi deleted the feat/enable-reetrancy branch December 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants