Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): RobotContext add run log commands #17040

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

Laura-Danielle
Copy link
Contributor

Overview

Any movement related commands in the robot context should have run logs associated with them.

Test Plan and Hands on Testing

  1. Check that run logs get generated for robot commands.

Changelog

  • Add run logs to robot context commands

Review requests

Check that the run log messages make sense.

Risk assessment

Low. Adding run logs to un-used API.

@Laura-Danielle Laura-Danielle requested a review from a team as a code owner December 4, 2024 21:49
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, are we going to do the app too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants