Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid Classes drafting for PAPI docs 2.22 #17111

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

emilyburghardt
Copy link
Collaborator

@emilyburghardt emilyburghardt commented Dec 13, 2024

Overview

First drafting of support for three defined liquid classes; NOT to be merged. Created a new article for liquids that will include previous liquids information and added liquid classes text.

Test Plan and Hands on Testing

Sandbox. Will continue committing and editing as I write.

Changelog

-new liquids article in PAPI docs (for all liquids information, including previous. liquid classes description is added for three defined classes, and can expand in this article as we develop editable liquid classes).
-moved "Labeling Liquids in Wells" from new_labware.rst to new liquids.rst article

Review requests

guidance filling in code blocks. what else do we need to document for users in this MVP release?

Risk assessment

low

@emilyburghardt emilyburghardt requested a review from a team as a code owner December 13, 2024 23:31
Copy link
Collaborator Author

@emilyburghardt emilyburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much under construction! Feedback would be appreciated.

.. _liquids:

########
Liquids
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new liquids article, and new overall description of liquids. previously, any information about liquids (define and specifying which well they were in) was under "Labware."

.. _labeling-liquids:

*************************
Labeling Liquids in Wells
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section was previously in "Labware" and was written by Ed.


Define a liquid class to automatically populate advanced settings in your protocol optimized for use with any of three liquid classes.

- **Aqueous liquids**, based on deionized water, and the system default.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially expand into a table below to describe major differences between liquid class definitions: speed, flow rate, etc.

Users will want to know what changes and advanced settings they are adding to their protocol. Review JSON definitions for this.


def define_liquid_class(Viscous)

**TODO**: fill in code-block example when ``define_liquid_class`` is used. what do users see?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kinds of arguments do users see returned for define_liquid_class? In the API proposal Sanniti suggested that liquid handling properties would be returned. Editing them isn't supported yet, but do users see them?

**TODO**: fill in code-block example when ``define_liquid_class`` is used. what do users see?

To transfer liquids of a defined class, use ``transfer_liquid``, just as you would for any liquid transfer. Here, you'll only specify source and destination wells and transfer volume. The liquid class definition contains all the other required information.
**TODO**: fill in code-block example for transferring a viscous liquid; defined with that class
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think source, destination, volume, new_tip, and trash location are returned for transfer_liquid. Want to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant