Refactor ECCC functionality and create Preprocess module #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved many eccc conversion functions to new preprocessing module * created new vocabularies module for CV support of multiple projects * json mappings are now configs * CF conversion will be handled by convert only - WIP
…as a dynamic and shared utility, renaming of configuration files for better coupling
Zeitsperre
changed the title
|
This is obviously not done, but I'd like to merge both this and your branch for RSDS then start cleaning things up. |
|
I still have a bunch of unpushed commits for the rdrs branch |
tlogan2000
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Yes, very much so. There are a lot of functions that have been pulled into the new
preprocessingmodule, and the ECCC-related code base is completely changed.Other information:
This is nowhere near ready. There's a strong possibility that the flat-file-handling code will be pulled entirely, as we will be moving towards an approach based entirely on calls to ECCC's GEOMET service. To be determined.