Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NRCan Gridded support #172

Draft
wants to merge 4 commits into
base: fix_eccc
Choose a base branch
from
Draft

Add NRCan Gridded support #172

wants to merge 4 commits into from

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 18, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Adds a configuration file for treating the NRCan Gridded 10Km dataset

Does this PR introduce a breaking change?

No.

Other information:

FYI @juliettelavoie @vindelico

@Zeitsperre Zeitsperre requested review from juliettelavoie and removed request for juliettelavoie March 18, 2024 18:58
@juliettelavoie
Copy link
Collaborator

juliettelavoie commented Mar 18, 2024

What do you think of calling it NRCANmet instead of NRCAN to fit with PCIC? more context: https://github.com/Ouranosinc/ouranos_data_catalog/pull/33)
@vindelico, in your exchanges with them, what do they call it ?

Also, it would be nice to add the version in the attrs.

@vindelico
Copy link

vindelico commented Mar 19, 2024

What do you think of calling it NRCANmet instead of NRCAN to fit with PCIC? more context: Ouranosinc/ouranos_data_catalog#33)

Je proposait camel case: NRCanMet

@vindelico, in your exchanges with them, what do they call it ?

I have no confirmed information about that but I think they speak of it in terms of ANUSPLIN.
If they transfer their production log files as promised we might know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants