This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Identifiables #211
Open
Identifiables #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedediah
force-pushed
the
identifiables
branch
from
aa81871 to
ed5937c
Compare
jedediah
force-pushed
the
identifiables
branch
from
ed5937c to
19e1624
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifiablefor things identified by aUUID, i.e.Entitys andOfflinePlayers.ConnectedPlayerinterface betweenOfflinePlayerandPlayerin the inheritance hiearchy, which adds a field for IP address. Use this to carry info in pre-login events.Event#getInvolved()that returns a list of allIdentifiables involved in the event.This seems like a better approach than
EntityActionandPlayerAction, and we may remove that patch if this one serves our needs.