This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Custom text rendering API #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedediah
commented
Jan 20, 2017
| @@ -18,12 +18,14 @@ | |||
| + public SocketAddress l; | |||
| + public java.util.UUID spoofedUUID; | |||
| + public com.mojang.authlib.properties.Property[] spoofedProfile; | |||
| + | |||
| + public int protocolVersion = Protocol.LATEST; | |||
| + public java.util.UUID playerId; | |||
| + | ||
| + @Override | ||
| + public void render(Player viewer) { | ||
| + ((RenderableComponent) a).render(viewer); |
There was a problem hiding this comment.
RenderableComponent.render()
| for(Plugin plugin : getPluginManager().getPlugins()) { | ||
| if(plugin.isEnabled()) { | ||
| for(Provider<TextRenderer> renderer : plugin.textRenderers()) { | ||
| text = renderer.get().render(this, text, viewer); |
|
|
||
| import org.bukkit.entity.Player; | ||
|
|
||
| public interface Renderable { |
There was a problem hiding this comment.
Rename this to something more specific
|
|
||
| import static com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| public class RenderableComponent extends ChatBaseComponent { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements OvercastNetwork/minecraft-api#6
RenderableComponentholds an originalBaseComponentand a map ofUUID->BaseComponentrendered for each viewer. It also implementsIChatBaseComponent, so it can be smuggled through without adding any fields to packets. The packets that use it implementRenderable, whichPlayerConnectioncalls to render the text for each viewer, on the main thread, just before sending the packet. The player's UUID is stored inPacketDataSerializer, and used to lookup the rendered text on the I/O thread.