profile guided optimization release

res/cmake/def.cmake

@@ -8,9 +8,26 @@ else() # !Clang
   set (PHARE_FLAGS ${PHARE_FLAGS} --param=min-pagesize=0 )
 endif() # clang
 
+set (PHARE_LINK_FLAGS )
+set (PHARE_BASE_LIBS )
+
+if(PGO_GEN)
+  if(PGO_USE)
+    message(FATAL_ERROR "cannot generate and use pgo at the same time.")
+  endif()
+  set (PHARE_LINK_FLAGS ${PHARE_LINK_FLAGS} -fprofile-generate )
+  set (PHARE_FLAGS ${PHARE_FLAGS} -fprofile-generate )
+endif()
+
+if(PGO_USE)
+  set (PHARE_LINK_FLAGS ${PHARE_LINK_FLAGS} -fprofile-use )
+  set (PHARE_FLAGS ${PHARE_FLAGS} -fprofile-use )
+endif()
+
+
 set (PHARE_WERROR_FLAGS ${PHARE_FLAGS} ${PHARE_WERROR_FLAGS})
 set (PHARE_PYTHONPATH "${CMAKE_BINARY_DIR}:${CMAKE_SOURCE_DIR}/pyphare")
-set (PHARE_BASE_LIBS )
+
 
 # now we see if we are running with configurator
 if (phare_configurator)

res/cmake/options.cmake

@@ -70,6 +70,12 @@ option(lowResourceTests "Disable heavy tests for CI (2d/3d/etc" OFF)
 option(testDuringBuild "Runs C++ unit tests after they are built" OFF)
 
 
+# -DPGO_GEN=OFF profile guided optimization generate
+option(PGO_GEN "profile guided optimization generate" OFF)
+# -DPGO_USE=OFF
+option(PGO_USE "profile guided optimization use" OFF)
+
+
 # Controlling the activation of tests
 if (NOT DEFINED PHARE_EXEC_LEVEL_MIN)
   set(PHARE_EXEC_LEVEL_MIN 1)

res/cmake_pgo_go.sh

@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+# usage:
+#  build PHARE with profile guilded optimizations
+
+set -ex
+SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+cd $SCRIPT_DIR && cd .. && CWD=$PWD # move to project root
+
+[ ! -f "$CWD/CMakeLists.txt" ] && echo "script expected to be run from project root" && exit 1
+[ ! -d "$CWD/subprojects/cppdict/include" ] && git submodule update --init
+
+export OPYTHONPATH=${PYTHONPATH}
+export PYTHONPATH=${PWD}:${PWD}/build:${PWD}/pyphare:${OPYTHONPATH}
+
+THREADS=${THREADS:-"10"}
+BUILD_DIR=${BUILD_DIR:-"$CWD/build"}
+SAMRAI=${SAMRAI:-""} # "" = from system or as subproject if not found in system
+[[ -n "${SAMRAI}" ]] && SAMRAI=-DSAMRAI_ROOT="${SAMRAI}"
+
+CMAKE_CXX_FLAGS="-DNDEBUG -g0 -O3 -march=native -mtune=native"
+CMAKE_CONFIG=" -Dphare_configurator=ON -DCMAKE_BUILD_TYPE=Release"
+
+export CC=${CC:-"gcc"}
+export CXX=${CXX:-"g++"}
+set -xe
+
+mkdir -p ${BUILD_DIR}
+(
+    cd ${BUILD_DIR}
+
+    cmake $CWD ${SAMRAI} ${CMAKE_CONFIG} -G Ninja -DCMAKE_CXX_FLAGS="${CMAKE_CXX_FLAGS}" -DPGO_GEN=ON;
+    ninja -v -j${THREADS} cpp cpp_etc dictator
+    python3 tests/functional/harris/harris_2d_2.py
+
+    cmake $CWD ${SAMRAI} ${CMAKE_CONFIG} -G Ninja -DCMAKE_CXX_FLAGS="${CMAKE_CXX_FLAGS}" -DPGO_GEN=OFF -DPGO_USE=ON;
+    ninja -v -j${THREADS} cpp cpp_etc dictator
+    python3 tests/functional/harris/harris_2d_2.py # should be faster than without any PGO
+)

src/amr/CMakeLists.txt

@@ -91,4 +91,5 @@ target_link_libraries(${PROJECT_NAME} PUBLIC
   SAMRAI_tbox
   SAMRAI_xfer
   )
+set_property(TARGET ${PROJECT_NAME} APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")
 

src/core/CMakeLists.txt

@@ -65,5 +65,5 @@ target_link_libraries(${PROJECT_NAME}  PRIVATE phare_initializer ${MPI_C_LIBRARI
 set_property(TARGET ${PROJECT_NAME} PROPERTY INTERPROCEDURAL_OPTIMIZATION ${PHARE_INTERPROCEDURAL_OPTIMIZATION})
 target_include_directories(${PROJECT_NAME}  PUBLIC ${MPI_C_INCLUDE_DIRS}
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../subprojects>)
-
+set_property(TARGET ${PROJECT_NAME} APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")
 

src/core/data/particles/particle.hpp

@@ -54,8 +54,8 @@ struct Particle
 
     Particle() = default;
 
-    double weight;
-    double charge;
+    double weight = 0;
+    double charge = 0;
 
     std::array<int, dim> iCell    = ConstArray<int, dim>();
     std::array<double, dim> delta = ConstArray<double, dim>();

src/core/numerics/ion_updater/ion_updater.hpp

@@ -185,6 +185,7 @@ void IonUpdater<Ions, Electromag, GridLayout>::updateAndDepositDomain_(Ions& ion
 
             if (copyInDomain)
             {
+                domain.reserve(domain.size() + enteredInDomain.size());
                 std::copy(enteredInDomain.begin(), enteredInDomain.end(),
                           std::back_inserter(domain));
             }

src/core/numerics/ohm/ohm.hpp

@@ -334,8 +334,8 @@ class Ohm : public LayoutHolder<GridLayout>
 
     template<auto component, typename VecField>
     auto hyperresistive_(VecField const& J, MeshIndex<VecField::dimension> index) const
-    {
-        return -nu_ * layout_->laplacian(J(component), index); // TODO : issue 3391
+    { // TODO : https://github.com/PHAREHUB/PHARE/issues/3
+        return -nu_ * layout_->laplacian(J(component), index);
     }
 };
 

src/core/numerics/pusher/boris.hpp

@@ -112,7 +112,7 @@ class BorisPusher
 
 
     /** see Pusher::move() documentation*/
-    void setMeshAndTimeStep(std::array<double, dim> ms, double ts) override
+    void setMeshAndTimeStep(std::array<double, dim> ms, double const ts) override
     {
         std::transform(std::begin(ms), std::end(ms), std::begin(halfDtOverDl_),
                        [ts](double& x) { return 0.5 * ts / x; });

src/core/utilities/cellmap.hpp

@@ -391,7 +391,7 @@ inline void CellMap<dim, cell_index_t>::empty()
 template<std::size_t dim, typename cell_index_t>
 template<typename Array, typename CellIndex, typename CellExtractor>
 inline void CellMap<dim, cell_index_t>::update(Array& items, std::size_t itemIndex,
-                                               CellIndex const& oldCell, CellExtractor extract)
+                                               CellIndex const& oldCell, CellExtractor /*extract*/)
 {
     // we want to check first if the particle is in the map
     // already. if is, needs to remove it before inserting it again

src/initializer/CMakeLists.txt

@@ -16,7 +16,7 @@ set(PYBIND11_CPP_STANDARD -std=c++17)
 add_library(${PROJECT_NAME} SHARED ${SOURCE_CPP} ${SOURCE_INC})
 target_compile_options(${PROJECT_NAME} PRIVATE ${PHARE_WERROR_FLAGS})
 set_property(TARGET ${PROJECT_NAME} PROPERTY INTERPROCEDURAL_OPTIMIZATION ${PHARE_INTERPROCEDURAL_OPTIMIZATION})
-
+set_property(TARGET ${PROJECT_NAME} APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")
 
 target_include_directories(${PROJECT_NAME}  PUBLIC
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../subprojects>)
@@ -30,3 +30,4 @@ set_target_properties(dictator
     PROPERTIES
     LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/pybindlibs"
 )
+set_property(TARGET dictator APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")

src/phare/CMakeLists.txt

@@ -16,5 +16,6 @@ target_link_libraries(phare-exe PUBLIC
     phare_simulator
     pybind11::embed
 )
+set_property(TARGET ${PROJECT_NAME} APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")
 
 

src/python3/CMakeLists.txt

@@ -11,6 +11,7 @@ set_target_properties(cpp
 )
 # this is on by default "pybind11_add_module" but can interfere with coverage so we disable it if coverage is enabled
 set_property(TARGET cpp PROPERTY INTERPROCEDURAL_OPTIMIZATION ${PHARE_INTERPROCEDURAL_OPTIMIZATION})
+set_property(TARGET cpp APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")
 
 if (CMAKE_BUILD_TYPE STREQUAL "Debug")
   pybind11_add_module(cpp_dbg cpp_simulator.cpp)
@@ -21,6 +22,7 @@ if (CMAKE_BUILD_TYPE STREQUAL "Debug")
       LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/pybindlibs"
   )
   set_property(TARGET cpp_dbg PROPERTY INTERPROCEDURAL_OPTIMIZATION ${PHARE_INTERPROCEDURAL_OPTIMIZATION})
+  set_property(TARGET cpp_dbg APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")
 endif (CMAKE_BUILD_TYPE STREQUAL "Debug")
 
 
@@ -33,3 +35,4 @@ set_target_properties(cpp_etc
 )
 # this is on by default "pybind11_add_module" but can interfere with coverage so we disable it if coverage is enabled
 set_property(TARGET cpp_etc PROPERTY INTERPROCEDURAL_OPTIMIZATION ${PHARE_INTERPROCEDURAL_OPTIMIZATION})
+set_property(TARGET cpp_etc APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")

src/simulator/CMakeLists.txt

@@ -20,4 +20,4 @@ target_link_libraries(${PROJECT_NAME} PUBLIC
   phare_amr # for mpicc
   phare_diagnostic
   )
-
+set_property(TARGET ${PROJECT_NAME} APPEND_STRING PROPERTY LINK_FLAGS " ${PHARE_LINK_FLAGS}")