-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty tables and nullable #17
base: main
Are you sure you want to change the base?
Conversation
@@ -40,7 +40,11 @@ read_table_encv1 <- function(dataset, set_index = TRUE) { | |||
columns <- columns[columns != "__categories"] | |||
|
|||
col_list <- lapply(columns, function(name) { | |||
values <- dataset[[name]]$read() | |||
if (dataset[[name]]$dims == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps add a comment referencing hhoeflin/hdf5r#118 so we know what this workaround is for (and can remove it in the future)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR! 🙇 When running this branch on
|
Hey @DriesSchaumont, Which version of Seurat / SeuratObject have you been using? We haven't covered Seurat 5 changes yet — the respective changes should probably land in another PR. A new issue might be a good start? 😃 Do you think the error you see here is also related to a modality with no features?.. |
Hi @gtca, that worked (although I could not use Seurat 4.4.0). Seurat v5 support would be great, but as you said: that would be for another PR 👍 |
Should make it possible to read more files out there as in #14